Skip to content

ci: set commit-lint step as optional #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

victorgz
Copy link
Collaborator

@victorgz victorgz commented Jan 17, 2022

Description

Set the commit-lint CI step as optional.
As we're squashing the commits in all the Pull Requests and using the PR title as the new one, it is not actually relevent if the names of the PR commits are following the angular convention or not.

Motivation and Context

People contributing might not follow the Angular convention for the commit names, but at the end, what is important for us is the PR title (because of Squash & Merge). Examples:
#46
#47

How Has This Been Tested?

Test Case: the PR includes a commit not compliant with the Angular convention. Commit name: "Test optional step with non compliant commit"
Result: the step outcome is marked as success, while the error is displayed in the step details. More info about step context here
image

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@victorgz victorgz force-pushed the refactor/ci-optional-commit-lint branch from 9def974 to 023f59a Compare January 17, 2022 16:24
@victorgz victorgz marked this pull request as ready for review January 17, 2022 16:39
@victorgz victorgz requested a review from scolladon January 17, 2022 16:39
Copy link
Collaborator

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorgz victorgz merged commit 0a2a43e into master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants