Enable media element for castanets #255
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which device configuration scenarios does this CL aiming at? |
joonghunpark
reviewed
Oct 8, 2019
joonghunpark
left a comment
joonghunpark
left a comment
There was a problem hiding this comment.
LGTM. But please wait for review from someone others.
Author
Thats right. |
joonghunpark
reviewed
Oct 8, 2019
sm-venugopal
force-pushed
the
castanets_69
branch
from
0946dca to
be6456e
Compare
Contributor
|
Requested to rebuild the Android, as the android build fail occurred due to the network problem from the build server. |
Target running browser process need not support these features. These may cause unpredicted behaviour. Signed-off-by: Venugopal S M <[email protected]>
Added video hole preference setter/ getter. Video hole preference is also applied to each WebView. Signed-off-by: Venugopal S M <[email protected]>
A transparent quad is drawn to show through the video played at HW plane. This commit introduces VIDEO_HOLE flag. Signed-off-by: Venugopal S M <[email protected]>
- Added video hole types to media player type class. The order should be same as castanet player. - New APIs are added to interface class. Signed-off-by: Venugopal S M <[email protected]>
- Added interface for castanets WebMediaPlayer - Added renderer manager for managing WebMediaPlayer objects - Added IPCs Signed-off-by: Venugopal S M <[email protected]>
sm-venugopal
force-pushed
the
castanets_69
branch
from
be6456e to
234ce37
Compare
Author
|
Updated with Video hole support for inline playback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.