[Service Offloading] Allow getDisplayMedia in non-secure context. #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Service offloading, the android device gets contents for the webrtc server from the client device. The android device needs to use http protocol to access the client device, but getDisplayMedia does not work with http content. So, this patch allows that getDisplayMedia works on the http content by setting the document state to 'Secure'. Signed-off-by: Sunwoo Nam <[email protected]>
Contributor
Author
Chikdolman
approved these changes
Dec 17, 2020
Contributor
Chikdolman
left a comment
Chikdolman
left a comment
There was a problem hiding this comment.
LGTM. However, the patch should be merged after verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Service offloading, the android device gets contents for the webrtc server
from the client device. The android device needs to use http protocol to access
the client device, but getDisplayMedia does not work with http content.
So, this patch allows that getDisplayMedia works on the http content by setting
the document state to 'Secure'.