-
Notifications
You must be signed in to change notification settings - Fork 38
Enable Network Service to run on renderer device without dependency on Network File System. #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: castanets_63
Are you sure you want to change the base?
Conversation
35e388d to
a2d8cc3
Compare
mojo/edk/system/node_controller.cc
Outdated
| #if !defined(OS_MACOSX) && !defined(OS_NACL) && !defined(OS_FUCHSIA) | ||
| #if defined(CASTANETS) | ||
| ScopedPlatformHandle server_handle = mojo::edk::CreateTCPServerHandle(mojo::edk::kCastanetsBrokerPort); | ||
| static int port = mojo::edk::kCastanetsBrokerPortUtility; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will cause issue when opening second tab.
suyambulingamrm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior when opening second tab can be checked once.
|
As a first step, this change should be rebased. I wonder whether it is possible to change the file protocol file's path to include browser process running device's ip before start loading, so url loader could load through it. How do you think about, Madhav? |
|
Add support to load subresources on Network service. - Create socketpair between network and renderer for data communication for non broker processes. - load data via mojo messages - create channels between network, browser and renderer, browser. Signed-off-by: venu.musham <[email protected]>
Add support for local shared memory. Local shared memory between network and renderer process for sharing network resources loaded by url loader. This commit enables Network Service to run on renderer device without dependency on Network File System. To enable local shared memory, add below to gn args $ gn gen --args='enable_castanets=true enable_local_shared_memory=true' out/Default Signed-off-by: venu.musham <[email protected]>
|
|
Currently we will face some challenge when running network process on android.
|
Cleanup debugging code which prints resource contents
on output.
Signed-off-by: venu.musham [email protected]