fix(use): compare requested version against resolved symlink when --silent-if-unchanged is enabled #1454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using a version by
aliasand, setting the--silent-if-unchangedflag you don't get a truly silent execution. Running several times with the same option and version should stop producing output after the first invocation:Change
The path sent to comparison is, as I understand, a symlink. Following it and returning that instead seems to be just enough to fix the above issue.
Disclaimer
I don't have any means to test this other than:
If there is any other way I can test this (without introducing excess into the codebase), please let me know.