Skip to content

Conversation

@nicholaskl97
Copy link
Collaborator

@nicholaskl97 nicholaskl97 commented Oct 22, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Optimization v5 was recently released, prompting this change. The new compat entry for OptimizationBase includes v3, which should work, but has not been tested, since NeuralPDE currently requires Optimization v4, limiting OptimizationBase to v2.

Also uses [sources] in Project.toml to use local NeuralLyapunovProblemLibrary in testing instead of doing it in runtests.jl via Pkg.

@nicholaskl97 nicholaskl97 merged commit 962f93f into master Oct 24, 2025
8 of 11 checks passed
@nicholaskl97 nicholaskl97 deleted the optimizationbase branch October 24, 2025 19:13
@nicholaskl97 nicholaskl97 restored the optimizationbase branch October 24, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant