Skip to content

Refactoring and implementing unified tableau structure and generic perform_step! for SDIRK solver set #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
+1,258 −7,347
Open

Refactoring and implementing unified tableau structure and generic perform_step! for SDIRK solver set #2779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
900014f
refactor(SDIRK): unified tableau structure and generic perform_step!
KrishGaur1354 Jul 27, 2025
bbe9847
Merge branch 'SciML:master' into master
KrishGaur1354 Jul 29, 2025
9d1201c
Implemented generic additive splitting for KenCarp/Kvaerno methods an…
KrishGaur1354 Jul 29, 2025
8288658
Merge branch 'SciML:master' into master
KrishGaur1354 Aug 1, 2025
ba76fb1
Merge branch 'SciML:master' into master
KrishGaur1354 Aug 4, 2025
1c64aad
Made the requested changes
KrishGaur1354 Aug 4, 2025
d69d9e6
comments added
KrishGaur1354 Aug 4, 2025
e2aec3b
Fix: Add missing perform_step! methods for SDIRK algorithms
KrishGaur1354 Aug 6, 2025
38c7af4
Fixed: SSPSDIRK2Cache and TrapezoidCache Error should be fixed for now
KrishGaur1354 Aug 6, 2025
11cc123
SDIRK Project.toml: resolve merge conflicts, add test/extras, align c…
KrishGaur1354 Aug 8, 2025
498f3ac
Resolve all merge conflicts in OrdinaryDiffEqSDIRK/Project.toml
KrishGaur1354 Aug 8, 2025
885c77e
.
KrishGaur1354 Aug 8, 2025
8cb50fd
Merge branch 'master' into master
KrishGaur1354 Aug 8, 2025
12e7c16
Merge branch 'SciML:master' into master
KrishGaur1354 Aug 10, 2025
02fa048
SDIRK tests now pass: JET and Aqua
KrishGaur1354 Aug 10, 2025
fcb60ef
Replaced the hardcoded element and extended SDIRKTableau
KrishGaur1354 Aug 10, 2025
8b8b00d
Merge branch 'master' into master
KrishGaur1354 Aug 10, 2025
a8f533f
ensure it passes the test on the buildkite
KrishGaur1354 Aug 10, 2025
7774123
removed duplicate reexport values
KrishGaur1354 Aug 10, 2025
383e106
Merge branch 'master' into master
KrishGaur1354 Aug 17, 2025
0611319
made the changes to the toml file
curdlinrope Aug 17, 2025
60758a6
Updated as required for it
KrishGaur1354 Sep 7, 2025
17538ba
Merge branch 'master' into master
KrishGaur1354 Sep 7, 2025
e8b11de
Test Fixes
KrishGaur1354 Sep 8, 2025
f03df64
Merge branch 'SciML:master' into master
KrishGaur1354 Sep 17, 2025
8152d18
Made suggested changes
KrishGaur1354 Sep 17, 2025
eedab04
Fixed SDIRKConstantCache naming conflict
KrishGaur1354 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/OrdinaryDiffEqCore/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ version = "1.34.0"

[deps]
SciMLOperators = "c0aeaf25-5076-4817-a8d5-81caf7dfa961"
Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
Accessors = "7d9f7c33-5ae7-4f3b-8dc6-eff91059b697"
StaticArraysCore = "1e83bf80-4336-4d27-bf5d-d5a4f845583c"
FunctionWrappersWrappers = "77dc65aa-8811-40c2-897b-53d922fa7daf"
Expand Down Expand Up @@ -33,17 +32,18 @@ RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
FastPower = "a4df4552-cc26-4903-aec0-212e50a0e84b"
Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
DiffEqBase = "2b5f629d-d688-5b77-993f-72d75c75574e"
FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"
SciMLStructures = "53ae85a6-f571-4167-b2af-e1d143709226"
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"
Reexport = "189a3867-3050-52da-a836-e630ba90ab69"

[extras]
AllocCheck = "9b6a8646-10ed-4001-bbdc-1d2f46dfbb1a"
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
DiffEqDevTools = "f3b72e0c-5b89-59e1-b016-84e28bfd966d"
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
AllocCheck = "9b6a8646-10ed-4001-bbdc-1d2f46dfbb1a"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"

[compat]
Expand Down Expand Up @@ -95,7 +95,7 @@ Mooncake = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6"
EnzymeCore = "f151be2c-9106-41f4-ab19-57ee4f262869"

[targets]
test = ["DiffEqDevTools", "Random", "SafeTestsets", "Test", "JET", "Aqua", "AllocCheck"]
test = ["AllocCheck", "DiffEqDevTools", "Random", "SafeTestsets", "Test", "JET", "Aqua"]

[extensions]
OrdinaryDiffEqCoreEnzymeCoreExt = "EnzymeCore"
Expand Down
3 changes: 2 additions & 1 deletion lib/OrdinaryDiffEqDifferentiation/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
OrdinaryDiffEqDifferentiationSparseArraysExt = "SparseArrays"

[extras]
AllocCheck = "9b6a8646-10ed-4001-bbdc-1d2f46dfbb1a"
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
DiffEqDevTools = "f3b72e0c-5b89-59e1-b016-84e28bfd966d"
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
AllocCheck = "9b6a8646-10ed-4001-bbdc-1d2f46dfbb1a"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"

Expand All @@ -50,6 +50,7 @@ FiniteDiff = "2.27"
StaticArrayInterface = "1.8"
DifferentiationInterface = "0.7"
LinearSolve = "3.26"

ConstructionBase = "1.5.8"
LinearAlgebra = "1.10"
SciMLBase = "2.99"
Expand Down
14 changes: 8 additions & 6 deletions lib/OrdinaryDiffEqSDIRK/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,15 @@ RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
OrdinaryDiffEqNonlinearSolve = "127b3ac7-2247-4354-8eb6-78cf4e7c58e8"
DiffEqBase = "2b5f629d-d688-5b77-993f-72d75c75574e"
Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"

[extras]
AllocCheck = "9b6a8646-10ed-4001-bbdc-1d2f46dfbb1a"
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
DiffEqDevTools = "f3b72e0c-5b89-59e1-b016-84e28bfd966d"
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
AllocCheck = "9b6a8646-10ed-4001-bbdc-1d2f46dfbb1a"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"

[compat]
Expand All @@ -42,16 +43,17 @@ Aqua = "0.8.11"
MacroTools = "0.5"
julia = "1.10"
JET = "0.9.18, 0.10.4"
OrdinaryDiffEqNonlinearSolve = "<0.0.1, 1"
DiffEqBase = "6.177.2"
Reexport = "1.2.2"
ADTypes = "1.16"
RecursiveArrayTools = "3.36"
OrdinaryDiffEqNonlinearSolve = "1.13.0"
AllocCheck = "0.2"
DiffEqBase = "6.176"
Reexport = "1.2"
SafeTestsets = "0.1.0"
StaticArrays = "1.0"

[targets]
test = ["DiffEqDevTools", "Random", "SafeTestsets", "Test", "JET", "Aqua", "AllocCheck"]
test = ["AllocCheck", "DiffEqDevTools", "Random", "SafeTestsets", "Test", "JET", "Aqua"]

[sources.OrdinaryDiffEqDifferentiation]
path = "../OrdinaryDiffEqDifferentiation"
Expand All @@ -60,4 +62,4 @@ path = "../OrdinaryDiffEqDifferentiation"
path = "../OrdinaryDiffEqNonlinearSolve"

[sources.OrdinaryDiffEqCore]
path = "../OrdinaryDiffEqCore"
path = "../OrdinaryDiffEqCore"
17 changes: 9 additions & 8 deletions lib/OrdinaryDiffEqSDIRK/src/OrdinaryDiffEqSDIRK.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@ import OrdinaryDiffEqCore: alg_order, calculate_residuals!,
alg_cache, _vec, _reshape, @cache, isfsal, full_cache,
constvalue, _unwrap_val, _ode_interpolant,
trivial_limiter!, _ode_interpolant!,
isesdirk, issplit,
isesdirk, issplit, recursivefill!,
ssp_coefficient, get_fsalfirstlast, generic_solver_docstring,
_bool_to_ADType, _process_AD_choice, current_extrapolant!
using TruncatedStacktraces: @truncate_stacktrace
using MuladdMacro, MacroTools, FastBroadcast, RecursiveArrayTools
using SciMLBase: SplitFunction
using LinearAlgebra: mul!, I
using StaticArrays
import RecursiveArrayTools: recursivefill!
import OrdinaryDiffEqCore

using OrdinaryDiffEqDifferentiation: UJacobianWrapper, dolinsolve
Expand All @@ -32,17 +34,16 @@ using Reexport

include("algorithms.jl")
include("alg_utils.jl")
include("sdirk_caches.jl")
include("kencarp_kvaerno_caches.jl")
include("sdirk_perform_step.jl")
include("kencarp_kvaerno_perform_step.jl")
include("tableau_utils.jl")
include("sdirk_tableaus.jl")
include("unified_sdirk_tableaus.jl")
include("sdirk_caches.jl")
include("generic_sdirk_perform_step.jl")

export ImplicitEuler, ImplicitMidpoint, Trapezoid, TRBDF2, SDIRK2, SDIRK22,
Kvaerno3, KenCarp3, Cash4, Hairer4, Hairer42, SSPSDIRK2, Kvaerno4,
Kvaerno5, KenCarp4, KenCarp47, KenCarp5, KenCarp58, ESDIRK54I8L2SA, SFSDIRK4,
SFSDIRK5, CFNLIRK3, SFSDIRK6, SFSDIRK7, SFSDIRK8, Kvaerno5, KenCarp4, KenCarp5,
SFSDIRK4, SFSDIRK5, CFNLIRK3, SFSDIRK6,
SFSDIRK7, SFSDIRK8, ESDIRK436L2SA2, ESDIRK437L2SA, ESDIRK547L2SA2, ESDIRK659L2SA
SFSDIRK5, CFNLIRK3, SFSDIRK6, SFSDIRK7, SFSDIRK8, ESDIRK436L2SA2, ESDIRK437L2SA,
ESDIRK547L2SA2, ESDIRK659L2SA

end
Loading