Add "min" and "max" statistics implemented as ExtremeValueStatistic #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ExtremeValueStatistic - Add statistics docs
SPC-code
requested changes
Apr 16, 2025
Contributor
SPC-code
left a comment
SPC-code
left a comment
There was a problem hiding this comment.
Looks mostly good, but scope pollution needs to be fixed for top level functions.
kmath-stat/src/commonMain/kotlin/space/kscience/kmath/stat/ExtremeValueStatistic.kt
Outdated
Show resolved
Hide resolved
kmath-stat/src/commonMain/kotlin/space/kscience/kmath/stat/ExtremeValueStatistic.kt
Outdated
Show resolved
Hide resolved
kmath-stat/src/commonMain/kotlin/space/kscience/kmath/stat/ExtremeValueStatistic.kt
Outdated
Show resolved
Hide resolved
- Remove ExtremeValueStatistic - Add benchmark
Contributor
Author
|
@SPC-code
|
SPC-code
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to maintainers:
This is first pull request for STUD-13 task.
The goal is to agree on template and style before adding more code. See statistics docs for the rest of statistics.
This is incomplete PR. Need to add test for ComposableStatistic. Need to learn Kotlin coroutines before.