Skip to content

Conversation

@stephenworsley
Copy link
Contributor

No description provided.

Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth addressing the NOX rules?
Or are you happy to defer to a future "QA Checklist" sprint?

@stephenworsley
Copy link
Contributor Author

Is it worth addressing the NOX rules? Or are you happy to defer to a future "QA Checklist" sprint?

The recomendations include using uv to run nox. There's probably a good case for this, but since this isn't in our stack at the moment it's probably also sensible to defer this. It's worth raising as it's own issue, but looks like a big enough job that getting this unblocked is probably worth doing in the mean time.

Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. LGTM.

@ukmo-ccbunney ukmo-ccbunney merged commit 39e9414 into SciTools:pre-commit-ci-update-config Nov 20, 2025
16 checks passed
stephenworsley added a commit that referenced this pull request Nov 20, 2025
* chore: update pre-commit hooks

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.12.11 → v0.14.5](astral-sh/ruff-pre-commit@v0.12.11...v0.14.5)
- [github.com/adamchainz/blacken-docs: 1.19.1 → 1.20.0](adamchainz/blacken-docs@1.19.1...1.20.0)
- [github.com/pre-commit/mirrors-mypy: v1.17.1 → v1.18.2](pre-commit/mirrors-mypy@v1.17.1...v1.18.2)
- [github.com/scientific-python/cookie: 2025.05.02 → 2025.11.10](scientific-python/cookie@2025.05.02...2025.11.10)

* address CI failures (#594)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: stephenworsley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants