Skip to content

Conversation

stephenworsley
Copy link
Contributor

Closes #5485

Supports the cannonical coordinates of the Geostationary coord system (projection_x_angular_coordinate, projection_y_angular_coordinate) and their cannonical unit (radians).

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.72%. Comparing base (a47fd34) to head (5ed2426).
Report is 324 commits behind head on main.

Files with missing lines Patch % Lines
lib/iris/analysis/_regrid.py 20.00% 3 Missing and 1 partial ⚠️
lib/iris/fileformats/_nc_load_rules/actions.py 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5745    +/-   ##
========================================
  Coverage   89.71%   89.72%            
========================================
  Files          90       91     +1     
  Lines       22815    22924   +109     
  Branches     5438     5462    +24     
========================================
+ Hits        20468    20568   +100     
- Misses       1617     1622     +5     
- Partials      730      734     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephenworsley! It's presumably on your radar to add tests to cover each of these changes?

@stephenworsley
Copy link
Contributor Author

@trexfeathers Yes that's the plan, I just need to figure out how to get the appropriate test data.

@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 24, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Regridding fails for geostationary coordinate systems

3 participants