Align manifest to template #218
Conversation
| #--------- | ||
| # SECTION: requirements | ||
| prune requirements | ||
| recursive-include requirements *.yml |
There was a problem hiding this comment.
YAML files are specifically the ones that we don't want to be included. I appreciate that there are no .txt files currently but we would want to include those were they ever added.
| # hints: | ||
| # - not all projects include requirements, but they can be drawn in anyway by dynamic dependencies | ||
| # in the setuptools build process, linked via config in pyproject.toml | ||
| # - for some repos, the *.txt are actually lockfiles. This probably needs fixing. |
There was a problem hiding this comment.
SciTools/.github#181 removes this line, if you wanted to align with that now?
| #--------- | ||
| # SECTION: docs | ||
| prune docs | ||
| # and if required ... include ONLY docs source files. | ||
| # E.G. recursive-include docs *.rst *.inc | ||
| # principles: | ||
| # - use prune to ignore everything (optionally: except the docs sources) | ||
| # hints: | ||
| # - most projects don't want to package the docs, but some currently do (cf-units). |
There was a problem hiding this comment.
SciTools/.github#181 makes changes to the docs entry, if you wanted to align with that now?
| exclude CODE_OF_CONDUCT.md | ||
| include COPYING | ||
| include COPYING.LESSER | ||
| include environment.yml |
There was a problem hiding this comment.
Should be excluded, if the template is to be believed.
This should be in a tephi-specific section at the bottom.
| include .git-blame-ignore-revs | ||
| exclude Makefile | ||
| exclude codecov.yml | ||
| include noxfile.py | ||
| include tox.ini |
There was a problem hiding this comment.
Should be in a Tephi-specific section at the bottom.
There was a problem hiding this comment.
Update: SciTools/.github#183; need to port those changes into here
| prune .coverage | ||
| # (2) top-level files to omit | ||
| exclude .coveragerc | ||
| exclude index.ipynb |
There was a problem hiding this comment.
Should be in a Tephi-specific section at the bottom.
|
@ESadek-MO can you explain why this is failing the tests? |
|
CI should be fixed with #219 |
🚀 Pull Request
Description