Skip to content

Conversation

@mittagessen
Copy link

Right now there are no timeouts on any of the API requests. I've added the timeout option on the global state which sets the requests package timeout argument on all the calls.

I can add a short documentation sentence about it to the readme, perhaps in the "On queries and performance" section?

Regarding tests, I'm unsure on how to add sensible ones.

@teleyinex
Copy link
Member

Hi,

This is nice :D Quick thing, before merging anything we need you to sign our Contributor Agreement

Now, back to your code: I would say, that for tests we have to mock the request, and make it timeout, so the requests package uses it. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants