Skip to content

Enabling Usage on GPUs other than GPUs 0-4 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Enabling Usage on GPUs other than GPUs 0-4 #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9c2a1d
make it possible to do pipeline rl runs on gpus other 0-3 so users ca…
icwhite Oct 13, 2025
c302c61
Merge branch 'main' of https://github.com/icwhite/PipelineRL into main
icwhite Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions pipelinerl/launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
os.environ["VLLM_LOGGING_LEVEL"] = "DEBUG"
os.environ["TORCH_FORCE_NO_WEIGHTS_ONLY_LOAD"] = "1"

VISIBLE_GPUS = os.getenv("CUDA_VISIBLE_DEVICES")

def _popen(
cmd: list[str],
env: dict | None = None,
Expand Down Expand Up @@ -100,7 +102,11 @@ def run_ref_llm(cfg: DictConfig, preprocessor_llm_idx: int, local_idx: int, gpus
if v not in [None, ""]:
cmd.append(str(v))

gpu_str = ",".join([str(gpu) for gpu in gpus])
visible_gpus = VISIBLE_GPUS.split(',')
if len(visible_gpus) == 0:
gpu_str = ",".join([str(gpu) for gpu in gpus])
else:
gpu_str = ",".join([str(visible_gpus[gpu]) for gpu in gpus])
logger.info(f"Running reference LLM with command: {' '.join(cmd)} with gpus: {gpu_str}")
log_file_path = os.path.join(log_dir, "stdout.log")
err_file_path = os.path.join(log_dir, "stderr.log")
Expand Down Expand Up @@ -160,7 +166,8 @@ def run_actor_llm(
if cfg.debug.mode:
cmd.append("--disable-weight-updates")

gpu_str = ",".join([str(gpu) for gpu in gpus])
visible_gpus = VISIBLE_GPUS.split(',')
gpu_str = ",".join([str(visible_gpus[gpu]) for gpu in gpus])
logger.info(f"Running actor_llm with command: {' '.join(cmd)} on gpus: {gpu_str}")
save_command(log_dir, cmd)
log_file_path = os.path.join(log_dir, "stdout.log")
Expand Down Expand Up @@ -290,10 +297,14 @@ def run_finetune(cfg: DictConfig, world_map: WorldMap, gpus: list[int], exp_dir:
"c10d",
]
if gpus:
gpus_str = str(",".join([str(gpu) for gpu in gpus])) if len(gpus) < world_map.node_size else "all"
visible_gpus = VISIBLE_GPUS.split(',')
if len(visible_gpus) == 0:
gpu_str = ",".join([str(gpu) for gpu in gpus])
else:
gpu_str = ",".join([str(visible_gpus[gpu]) for gpu in gpus])
cmd += [
"--gpu-ids",
gpus_str,
gpu_str,
]
cmd += [
"--num_processes",
Expand Down