Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Commit bd55624

Browse files
committed
Merge pull request #218 from ServiceStack/ci-testing-singlehost
Check for EnvVar CI_REDIS for localhost tests
2 parents c65020b + 41f6b52 commit bd55624

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

tests/ServiceStack.Redis.Tests/ConfigTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ private static void AssertClient(RedisClient redis, RedisEndpoint expected)
116116
[Test]
117117
public void Does_set_Client_name_on_Connection()
118118
{
119-
using (var redis = new RedisClient("localhost?Client=nunit"))
119+
using (var redis = new RedisClient(TestConfig.SingleHost + "?Client=nunit"))
120120
{
121121
var clientName = redis.GetClient();
122122

@@ -127,7 +127,7 @@ public void Does_set_Client_name_on_Connection()
127127
[Test]
128128
public void Does_set_Client_on_Pooled_Connection()
129129
{
130-
using (var redisManager = new PooledRedisClientManager("localhost?Client=nunit"))
130+
using (var redisManager = new PooledRedisClientManager(TestConfig.SingleHost + "?Client=nunit"))
131131
using (var redis = redisManager.GetClient())
132132
{
133133
var clientName = redis.GetClient();

tests/ServiceStack.Redis.Tests/Examples/SimpleLocks.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public void AcquireLock_using_Tasks()
123123
{
124124
Console.WriteLine("About to process " + clientNo);
125125
//var redisClient = new RedisClient("xxxx.redis.cache.windows.net", 6379, "xxxx");
126-
var redisClient = new RedisClient("localhost", 6379);
126+
var redisClient = new RedisClient(TestConfig.SingleHost, 6379);
127127

128128
using (redisClient.AcquireLock("testlock1", TimeSpan.FromMinutes(3)))
129129
{

tests/ServiceStack.Redis.Tests/Issues/RedisCharacterizationTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ public void RedisManagerPool_WhenUsingADatabaseOnARedisConnectionString_CorrectD
4343

4444
private void TestForDatabaseOnConnectionString(Func<string, IRedisClientsManager> factory)
4545
{
46-
_db1ClientManager = factory("localhost?db=1");
47-
_db2ClientManager = factory("localhost?db=2");
46+
_db1ClientManager = factory(TestConfig.SingleHost + "?db=1");
47+
_db2ClientManager = factory(TestConfig.SingleHost + "?db=2");
4848

4949
using (var cacheClient = _db1ClientManager.GetCacheClient())
5050
{
@@ -59,8 +59,8 @@ private void TestForDatabaseOnConnectionString(Func<string, IRedisClientsManager
5959
[Test]
6060
public void WhenUsingAnInitialDatabase_CorrectDatabaseIsUsed()
6161
{
62-
_db1ClientManager = new BasicRedisClientManager(1, "localhost");
63-
_db2ClientManager = new BasicRedisClientManager(2, "localhost");
62+
_db1ClientManager = new BasicRedisClientManager(1, TestConfig.SingleHost);
63+
_db2ClientManager = new BasicRedisClientManager(2, TestConfig.SingleHost);
6464

6565
using (var cacheClient = _db1ClientManager.GetCacheClient())
6666
{

tests/ServiceStack.Redis.Tests/TestConfig.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using System;
12
using ServiceStack.Logging;
23
using ServiceStack.Support;
34

@@ -12,7 +13,10 @@ static TestConfig()
1213

1314
public const bool IgnoreLongTests = true;
1415

15-
public const string SingleHost = "localhost";
16+
public static string SingleHost
17+
{
18+
get { return Environment.GetEnvironmentVariable("CI_REDIS") ?? "localhost"; }
19+
}
1620
public static readonly string[] MasterHosts = new[] { "localhost" };
1721
public static readonly string[] SlaveHosts = new[] { "localhost" };
1822

0 commit comments

Comments
 (0)