fix(🗑️): fix Hermes memory pressure tracking for recorder pictures #3495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wcandillon
commented
Oct 31, 2025
wcandillon
commented
- Ensure each container owns a single JSIRecorder, preventing redundant host object churn and keeping Hermes’ accounting stable.
- Update existing SkPicture wrappers in play() to refresh memory pressure after swapping in newly recorded pictures so Hermes observes native usage growth.
- Align picture handling across the codebase so recorder playback can no longer leak native memory under Hermes in heavy scenes.
Increased timeout duration for WebSocket closure.
wcandillon
changed the title
Contributor
|
🎉 This PR is included in version 2.3.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.