Adds support for attr_* method references #3706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests. Prob can use some cleanup
…r-method-references
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
tommycrumrine
changed the title
egiurleo
reviewed
Sep 30, 2025
| if @target.is_a?(MethodTarget) && (name = node.name.to_s) == @target.method_name | ||
| @references << Reference.new( | ||
| name, | ||
| node.message_loc, #: as !nil |
There was a problem hiding this comment.
Does type checking pass without this #: as !nil?
| def unescaped_argument_names(node) | ||
| return [] if node.arguments.nil? | ||
|
|
||
| node.arguments.arguments.select { |arg| arg.respond_to?(:unescaped) }.map(&:unescaped) |
There was a problem hiding this comment.
Can node.arguments.arguments be nil?
egiurleo
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Shows references for methods defined with
attr_reader,attr_writer,attr_accessorRe-opening stale PR #2848. Sorry this fell off my radar!
Closes #2668
Implementation
attr_reader,attr_writer,attr_accessorare just methods, so on call node if we detect one of these methods, and one of the arguments match the target method name, add the reference.Additionally, I have ensured it works with empty and string arguments as well as added tests for these cases.
Automated Tests
Yes!
Manual Tests