fix uninitialized variables #1
Conversation
added const-ness and proper initialization.
| struct State { | ||
| Array real, imag; | ||
| }; | ||
| State newState; |
There was a problem hiding this comment.
Why does this need to be in the class, instead of a stack variable?
geraintluff
left a comment
geraintluff
left a comment
There was a problem hiding this comment.
I think I might not understand what this is fixing. Could you give an example of the warning/error you get, or the unexpected behaviour this is preventing?
| // Really we're just doing: state[i] = state[i]*poles[i] + x*coeffs[i] | ||
| // but std::complex is slow without -ffast-math, so we've unwrapped it | ||
| State state = states[channel], newState; | ||
| State& state = states[channel]; |
There was a problem hiding this comment.
Is changing this to a reference deliberate?
| } | ||
|
|
||
| Complex operator()(Sample x, int channel=0) { | ||
| std::pair<Sample, Sample> operator()(Sample x, int channel=0) { |
There was a problem hiding this comment.
Is there an advantage over Complex, and shouldn't this match the other operator() as well?
| struct HilbertIIRCoeffs { | ||
| static constexpr int order = 12; | ||
| std::array<std::complex<Sample>, order> coeffs{{ | ||
| const std::array<std::complex<Sample>, order> coeffs{{ |
There was a problem hiding this comment.
Were these giving warnings in a particular compiler, without const? Or was this for tidiness? 😄
|
Hi @aleksandarkoruga! Just checking in to see if you'd read my comments. I appreciate the PR, but just need to understand it fully before I can do anything with it. |
2 participants
added const-ness and proper initialization.