-
Notifications
You must be signed in to change notification settings - Fork 93
[MNT] isolate scikit-learn
#82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
epsilon=0.03, | ||
distribution="normal", | ||
n_neighbours=3, | ||
estimators=[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mutable defaults should never be used - general python thing, not specific to sklearn
isolation
This would lead to a worse "out of the box" experience for the user, since using these optimizers will raise an error if sklearn is not already installed, right? Sklearn is not an optional dependency, but is (at the moment) required for the use of the supported optimization algorithms of this package. This way sklearn can be a true optional dependency. |
Hm, yes, if we move However, if we do not change |
yes, this will work fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task: remove changes in pyproject.toml
I think we should make
scikit-learn
an optional dependency ofgfo
.Otherwise, currently,
hyperactive
depends ongfo
, andgfo
onscikit-learn
, making it a required dependency - even though it is used only in a small number of places.This PR "isolates"
scikit-learn
in the sense that:scikit-learn
is installed as a test dependency instead of as a core dependencyAlso does some other minor things: