Skip to content

Conversation

@Absolutionism
Copy link
Contributor

Problem

With the introduction of Mannequins into Minecraft, Skript does not yet have support for customizing a Mannequin.

Solution

Updates existing syntax to work with Mannequins
'CondIsLeftHanded' - to check if a mannequins main hand is left hand or right hand
'EffHandedness' - to set the main hand of a mannequin

Adds new syntax
'CondMannequinImmovable' - to check if a mannequin is immovable/movable
'CondMannequinParts' - to check which skin parts of a mannequin is enabled/disabled
'EffMannequinImmovable' - to make a mannequin immovable/movable
'EffMannequinParts' - to enable/disable skin parts of a mannequin
'ExprMannequinBody' - the body texture of a mannequin
'ExprMannequinCape' - the cape texture of a mannequin
'ExprMannequinDesc' - the description of a mannequin
'ExprMannequinElytra' - the elytra texture of a mannequin
'ExprMannequinModel' - the skin model of a mannequin
'ExprMannequinSkin' - the skin of a mannequin. outputs and intakes an offline player or a texture value.

Utils
'ResolvableProfileBuilder' - Helper class for converting a ResolvableProfile to a builder with all data retained
'SkinPatchBuilder' - Helper class for converting a SkinPatch to a builder with all data retained

Testing Completed

EntityData.sk
EffHandedness.sk
EffMannequinImmovable.sk
EffMannequinParts.sk
ExprMannequinBody.sk
ExprMannequinCape.sk
ExprMannequinDesc.sk
ExprMannequinElytra.sk
ExprMannequinModel.sk
ExprMannequinSkin.sk

Supporting Information

N/A


Completes: none
Related: none

@Absolutionism Absolutionism added the 2.14 Targeting a 2.14.X version release. label Nov 2, 2025
@Absolutionism Absolutionism requested review from a team as code owners November 2, 2025 05:16
@Absolutionism Absolutionism requested review from UnderscoreTud and erenkarakal and removed request for a team November 2, 2025 05:16
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Nov 2, 2025
@Absolutionism Absolutionism moved this to In Review in 2.14 Releases Nov 2, 2025
@Absolutionism Absolutionism added the feature Pull request adding a new feature. label Nov 2, 2025
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks high quality
I think a lot of the syntaxes can be improved though, especially to help prevent the user from having to type mannequin a bazillion times.

It can only contain one ':' to separate the namespace and the id. \
Only alphanumeric characters, periods, underscores, and dashes can be used.
""")
@Example("set the mannequin body of {_mannequin} to \"custom:body\"")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any vanilla ones we can use for examples so users can see the example work on their server?

if (mode == ChangeMode.SET) {
assert delta != null;
String string = (String) delta[0];
component = Component.text(string);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we be serializing this via normal skript methods to support skript color tags and formatting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at MessageComponent and ChatMessage, idk if those are the right place to do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that's where it's handled, not certain though.

@skriptlang-automation skriptlang-automation bot added needs reviews A PR that needs additional reviews and removed needs reviews A PR that needs additional reviews labels Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.14 Targeting a 2.14.X version release. feature Pull request adding a new feature. needs reviews A PR that needs additional reviews

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants