Skip to content

Conversation

@jpswinski
Copy link
Member

@jpswinski jpswinski commented Oct 2, 2024

Purpose

To directly include the OpenOceans++ classifier header from the sliderule code

Changes

  • Some #include directives were modified so that relative paths were consistently used. Reason: with in the sliderule build the same compilation unit will include both this classifier and other classifiers that have the exact same header filenames; this makes it difficult to set global include paths - evne if they are separated out when included from sliderule code, the locally included files are no longer able to be found

  • Fixed all occurrences of an aliased variable. Reason: sliderule builds enforce strict policies on compiler warnings (sometimes annoyingly so, but we've committed to it and it pays off).

@jpswinski jpswinski requested a review from jeffsp October 2, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants