Skip to content

Remove the need for restart before OTA on newer firmware #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loucass003 merged 2 commits into from
Dec 5, 2025
Merged

Remove the need for restart before OTA on newer firmware #1627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc74618
Remove the need for restart before OTA on newer firmware
loucass003 Nov 18, 2025
5643d98
spotless
loucass003 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions server/core/src/main/java/dev/slimevr/firmware/FirmwareUpdateHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,22 +222,35 @@ class FirmwareUpdateHandler(private val server: VRServer) :
LogManager.info("[FirmwareUpdateHandler] Device is already updating, skipping")
}

onStatusChange(
UpdateStatusEvent(
val udpDevice: UDPDevice? =
(server.deviceManager.devices.find { device -> device is UDPDevice && device.id == deviceId.id }) as UDPDevice?
if (udpDevice === null) {
error("invalid state - device does not exist")
}

if (udpDevice.protocolVersion <= 20) {
onStatusChange(
UpdateStatusEvent(
deviceId,
FirmwareUpdateStatus.NEED_MANUAL_REBOOT,
),
)
watchRestartQueue.add(
Pair(deviceId) {
mainScope.launch {
startFirmwareUpdateJob(
request,
deviceId,
)
}
},
)
} else {
startFirmwareUpdateJob(
request,
deviceId,
FirmwareUpdateStatus.NEED_MANUAL_REBOOT,
),
)
watchRestartQueue.add(
Pair(deviceId) {
mainScope.launch {
startFirmwareUpdateJob(
request,
deviceId,
)
}
},
)
)
}
} else {
if (updatingDevicesStatus[deviceId] != null) {
LogManager.info("[FirmwareUpdateHandler] Device is already updating, skipping")
Expand Down