Move getOrgFullScan to streamOrgFullScan and getOrgFullScanBuffered #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalton
force-pushed
the
main
branch
6 times, most recently
from
bc78346 to
3383127
Compare
jdalton
force-pushed
the
main
branch
6 times, most recently
from
2610ce0 to
1deeacd
Compare
jdalton
force-pushed
the
main
branch
5 times, most recently
from
7efd7d9 to
69c504f
Compare
jdalton
force-pushed
the
main
branch
4 times, most recently
from
f5f2ea4 to
5677ce2
Compare
jdalton
force-pushed
the
main
branch
5 times, most recently
from
5989ea2 to
6597379
Compare
jdalton
force-pushed
the
main
branch
5 times, most recently
from
75cf6d5 to
fd46308
Compare
jdalton
force-pushed
the
main
branch
3 times, most recently
from
71078f6 to
bf16455
Compare
jdalton
force-pushed
the
main
branch
4 times, most recently
from
c35c10e to
641d622
Compare
jdalton
force-pushed
the
main
branch
4 times, most recently
from
5efe171 to
f8bb5d9
Compare
jdalton
force-pushed
the
main
branch
11 times, most recently
from
bc631df to
fa9c870
Compare
|
This landed as part of our test coverage push 8400b0b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getOrgFullScanis a bit of a misnomer, especially since the rest doesn't stream the data.I'm moving the method to
streamOrgFullScanand deprecating the old method.Additionally, adding a new method
getOrgFullScanBuffere, which should make the distinction clear and not risk a sort of rug pull.We deprecate the old method and in some major we can complete the swap, or just drop it and leave it like this.