Skip to content

Conversation

dacoburn
Copy link
Collaborator

If there was a # in the params then parameters for Full Scan were not correctly passed to the Full Scan API due to not URL Encoding the params.

Changelog:

  • Updated the Full Scan logic to always URL encode the parameters for the Full Scans endpoint. This will keep URL breaking characters from causing issues.
  • Updated the User Agent string to not be generic and specifically call out being the SocketSDKPython

@dacoburn dacoburn added the product changelog Any public-facing change in the product's features label Mar 19, 2025
@dacoburn dacoburn requested a review from a team as a code owner March 19, 2025 15:00
@dacoburn dacoburn requested review from philidem and reberhardt7 and removed request for a team March 19, 2025 15:00
Copy link

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socket-sdk-python==2.0.13.dev283

@obarrera obarrera self-requested a review March 19, 2025 15:03
@dacoburn dacoburn merged commit 231ee35 into main Mar 19, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/make-params-url-safe branch March 19, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product changelog Any public-facing change in the product's features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants