chore: V8.4.2 main merge v2 BED-6953 #2203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: resolve typo in Linux abuse commands by renaming groupDistinguidedName to groupDistinguishedName * Save progress on OG extension migration and create/get db functions * Ran just generate * Cleaned up test * Fix some coderabbit findings. Cleaned up test. * Rework slightly to make use of the Serial base type * run just generate * Ensure is_builtin is set to FALSE in the Create handler. * I guess I could fix that, good call rabbit * BED-6783: implement create and get for graph schema properties * Make updated_at default to current_timestamp in db migration. * BED-6783: the rabbit knows all * BED-6783: Add methods to interface and generate mocks * BED-6783: fix sql * BED-6783: rename table * Change table name to schema_extensions * BED-6783: change naming scheme * BED-6783: update audit log name and test name * BED-6783: fix sql comment * BED-6783: fix doc string * Move db migration to 8.4.5.sql * chore(BED-5719): time utils for DateTime objects (#2055) * chore: add time constants for datePicker * test: floorToNearestMinute * chore: bump doodle version * Move migration to v8.5.0 * Add index to foreign key * BED-6783: remove audit entry * BED-6717: OpenGraph nodes are searchable on the explore page (#2061) * update search endpoint to not filter out opengraph nodes * update graph mocks * add tests for opengraph nodes * fix broken tests due to dropped () * WIP use new integration test suite * update tests and opengraph json * remove unused harness updates * refactor: test tables for tests * add OpenGraph Search feature flag * preserve original behavior if feature flag is off * update graph-search endpoint to include opengraph results * update tests for graph-search * move feature flag migration to v8.5.0 * removed unused variable, change node test setup * add graphquery reciever to helper functions * rename integration test setup file * pfc * feat: add db migration and methods to create and get graph schema extensions In support of opengraph phase 2 Closes BED-6777 (#2065) * feat: conventional commits format check workflow BED-5831 (#1400) * feat: add conventional commit format check workflow * chore: same line error message * fix: subject pattern matching * fix: actually fix pattern matching; update rfc * refactor: header pattern update - includes 'edited' to event triggers - uses header pattern with capture group of issue ref at front - tightens issue ref matching to specified boards (BED, PQE, or gh issues) - includes step for commenting on PR on failed validation - includes step for validating referenced issue exists in jira * refactor: ref check * chore: add debug logging, specify url with flag * fix: jira base url usage * fix: compact res with jq to output * fix: replace ubuntu latest with self hosted runner * chore: add push event trigger to test runner * chore: temporarily comment steps that rely on pull based triggers for testing runner * chore: hard code title since it relied on pull based triggers; testing runner * fix: update conditional for jira issue existence check * chore: empty commit * chore: random change so runner picks up workflow * chore:remove other event triggers * chore: change issue reference to non existing gh issue * chore: update issue ref to existing gh issue * fix: update gh ref conditional * chore: revert wip changes after testing ref check logic * fix: ignore main branch so workflow can merge to main; update rfc * fix: update format so it complies with the common spec * chore: convert workflow to reusable * fix: GITHUB_TOKEN collision * fix: ref head designation * fix: ref head designation * chore: print gh issue for inspection * chore: remove gh token in api call * chore: update uses specification to refrerence main branch * chore: cleanup debug echo * fix: gh condition check * chore: cleanup gh token * chore: remove response print * chore: page description and navigation improvements BED-6627 (#2095) * chore: BED-6810 (#2076) * BED-6810 added descriptions * running pfc * PR feedback * PR feedback * deleted files * removed unused code * PR feedback * feedback * updated descriptions * feedback * make labels link component * pfc * fixed test * coderabbit feedback * PR feedback * coderabbit suggestion * refactor: sx props to tailwind classes BED-6739 (#2033) * refactor: sx props to tailwind classes * fix: rabbit pr feedback * fix: citrix dialog open change handling * fix: correct width class * chore: sso style updates * fix: saved queries dialog styles and pr feedback * chore: add sx lint, add lint to ci, pfc updates * chore: unit test cleanup * BED-6740 chore: replace MUI useTheme usage (#2047) * chore: replace MUI useTheme usage * chore: duplicate export cleanup, useTheme code description addition * chore: sort and lint export order in shui * chore: cleanup defunct comment * fix: reorder worfklow steps because format is breaking lint * chore: remove conflicting order lint and fix spacing props * fix: remove unused vars * chore: cleanup commented require * fix: first render theme and misc style updates * fix: theme update import to fix test * chore: return to arbitrary values for label alignment * fix: guard html tag usage in non dom envs * feat(OpenGraph): DB - Create/Read Extension Node Kind Schema Entry - BED-6788 (#2083) * feat: add indicator for processing BED-6907 (#2104) * BED-6907 add indicator for processing * Added tests and fixed failing tests * pfc * PR feedback * chore: remove dead code (#2109) * Change revert sql migration * test: Added unit tests for the method ShareSavedQueries. BED-6855 (#2113) * Test: Added unit tests for the method ShareSavedQueries. BED-6855 * test: Removed unused variables. BED-6855 * fix: pattern matching and comment cleanup BED-6917 (#2115) * fix: pattern matching and comment cleanup BED-6917 * fix: remove github token secret specification * fix: trim pr title for white space * test: BED-6872 added unit test coverage (#2118) * fix: enable extended globbing for white space trimming in cc workflow BED-6925 (#2117) * fix(ApiExplorer): Modified the predicate filter files to use type string. BED-6051 (#2114) * Fix: Modified the predicate filter files to use type string. BED-6051 * fix: Added examples to the predicate filter files changed. BED-6051 * chore: update Zone Selector BED-6846 (#2103) * feature:BED-6846 add ZoneSelector to PZContext, add detailsPage to PZPathParams * feature:BED-6846 small style change to DynamicDeets icon * feature:BED-6846 pfc change * chore:BED-6846 refactor useSelectedTag to use fallbacks * chore:BED-6846 update params for ZoneSelector in PZContext * chore:BED-6846 useSelectedTag to use useAssetGroupTag * refactor: Added Unit tests for AssetGroupTags BED-6873 (#2119) * Started new branch with current changes * Updated Unit tests only for TestResources_CreateAssetGroupTagSelector function * Updated Unit Tests for TestDatabase_GetAssetGroupTagSelector * Updated Tests for TestResources_GetAssetGroupTagSelectors * Updated Tests for TestResources_DeleteAssetGroupTagSelector * Updated Tests for TestResources_GetAssetGroupTagMemberInfo * Updated Tests for Test_GetAssetGroupMembersBySelector * Testing key * Comp Sci * SearchAssetGroupTags gomock adjustments * test: BED-6873 Added unit tests for SearchAssetGroupTagHistory * test: BED-6873 Fixed 3/4 unit tests for SearchAssetGroupTagHistory * test: BED-6873 added final ToKind to fix Paginated call * Addressed review comments * Revert "fix(ApiExplorer): Modified the predicate filter files to use type str…" (#2122) This reverts commit 48fadd1. * feat(OpenGraph): DB - Create/Read Extension Edge Kind Schema Entry - BED-6790 (#2107) * feat: changed name member to object BED-6517 (#2112) * BED-6517 changed name member to object * pfc * feedback * changed back to node * changed urls * added string based on PZ path * feedback * refactor: additional navigation for edit zone on Privilege Zones BED-6628 (#2106) * refactor: modified Edit Zone Details card * refactor: "Relocated useTagLimit hook" * refactor: Added remaining labels * chore: Fixed closing tags * refactor: Made according changes * CR feedback * chore: "conditionally rendering delete button" * Created new test for useTagLimits hook * test: updated test * chore: rabbit feedback * chore: "made suggested changes" * chore: Made suggested changes * chore: made suggested changes * chore: exported ZonesLink * refactor: Made types adjustment * chore: Cleanup * feat(OpenGraph): DB - Update/Delete Extension Node Kind Schema Entry - BED-6793 (#2121) * feat(OpenGraph): Add update/delete for Graph Schema Extension Properties - BED-6785 (#2124) * BED-6785: add update and delete methods * BED-6785: add update and delete db methods * BED-6785: add better test coverage * BED-6785: change delete db action to exec * BED-6785: pfc * BED-6785: update test * feat(OpenGraph): DB - Update/Delete Extension Edge Kind Schema Entry - BED-6794 (#2125) * feat: Update explore search results to return custom node icon data BED-6887 * WIP custom icons for opengraph search * WIP custom icons for opengraph search, backend * set Type for nodes with opengraph kinds * set custom icons for opengraph nodes * update mocks * use nodetype field for icon kind * tests * coderabbit suggestion * pfc * chore: create new details page BED-6837 (#2102) * chore: create new details page * refactor: pz links and navigation * chore: remove 6835 implementation * chore: update links in tagtozonelabeldialog * chore: selector > rule * chore: selector to rule continued * chore: update comment for accuracy; more link updates * fix(Graph): Prevent zoom on graph double click - BED-6965 (#2139) * chore: upgraded vulnerabilities for CVE-2025-61729, CVE-2025-58181, CVE-2025-47914 (#2137) * chore: Drop unnecessary error logs to warn - BED-6663 (#2138) * chore:Drop unnecessary error logs to warn - BED-6663 * fix isStartCertTemplateValidESC3 since my logic was slightly off * remove sprintf and unnest some if else * add missing returns if err * remove a redundant return * chore(userstable): remove duplicate div (#2120) * feat: adjusted tag form UI BED-6854 (#2136) * BED-6854 adjusted tag form UI * pfc * feat(OpenGraph): Update and Delete schema extensions DB methods BED-6781 (#2141) * WIP UD graph schema extensions * add update for graph schemas * add and refactor tests * update mocks * use errorsIs for consistency * feat: OG DB - List/Query Extension Entries BED-6778 (#2091) Added the db function GetGraphSchemaExtensions() Closes BED-6778 --------- Co-authored-by: Alyx Holms <[email protected]> * chore: Generate UI Unit Test Results via Github Workflow Closes: BED-6561 * Capture all UI test resutls and install allure-js reporting dependencies * test allure github actions * append js client library test * update github context * - Fix condition on push events - Create seperate allure-reporting gh action * remove redundant conditions * fix typescript naming convension * update demo test implementation * add license content * - allure-js-commons dependency - add a placeholder test * update gh action * - Remove test placeholder and dependencies * remove allure-reporter * set reporter to verbose * Collect test results on main and stage branches * address CR comment * - Remove unused dependencies - Ping Vitest version to v3.0.0 * feat(OpenGraph): GetGraphSchemaNodeKinds - BED-6791 (#2135) * feat(PZ): Add Selector Type Counts for GET /api/v2/asset-group-tags BED-6821 (#2126) * feat(PZ): Add selector type counts for GET /api/v2/asset-group-tags * test: added new tests for adding Selector Type Counts * chore: just pfc * updated mocks with just generate * optimized GetAssetGroupTagSelectorCounts db functionality * fixed counts * chore: addressed PR feedback * fixed both api and database tests plus updated mocks * feat: Far reaching accessibility changes BED-5690 (#2010) * add a11y eslint dependency for accessible html * change name of click handler adapter * restore file from main * remove eslint disable * adjust actions and colors for accessibility * change signature of adaptClickHandlerToKeyDown * update tests with new selectors * update event types * add onBlur per linter * add anchor from DoodleUI * add accessibility to elements * restore doodleui * restore doodleui * add labels and other accessibility properties * upgrade doodle ui * update event handler for row clikc * add aria-label * remove redundant label * update tests for removed role * adjust pattern for cloning graph items * update downshift * add labels * add test id to input * add changes for accessible handlers * apply changes to child rendering to preserve onClick behavior * restore click functionality to div * update column headers logic for accessibility * add explicit label * simplify link style * update dependency array * add comment * adjust tests for new labels * remove sx * add accessibility props to file drop * update test for selectors -> rules change * verify uploading allure results artifacts * update github workflows to call work_call event * update the path * remove condition * add multiple workflows to download ui and go * fix the redirect * cleanup * upload test results on main only * fix condition error * feat(OpenGraph): DB - List/Query Extension Edge Kind Schema Entries - BED-6792 (#2155) * feat(OpenGraph): Add schema findings migrations BED-6751 (#2105) * update allure-vitest dev dependency * update expression * fix the expression * Update ci.yml chore: temporarily change cache mode * Update ci.yml chore: revert cache mode change * chore: Add Label Selector BED-6845 (#2157) * BED-6845 update useLabels, add hook for/default for selectedLabel, add LabelSelector to Context * chore:BED-6845 pfc * chore:BED-6845 remove hook from selectedTag and remove prop/rename in Context * fix: OG All files failed on one invalid relationship BED-6589 (#1968) Do not report unresolved relationships in an opengraph json file as failure of the entire file. * feat: added boolean enable updates BED-6856 (#2158) * BED-6856 added boolean enable updates * pfc * fix tests * PR feedback * feat(OpenGraph): DB - List/Query Extension Property Schema Entries - BED-6784 (#2159) * refactor: InfoHeader Updates BED-6835 (#2140) * refactor: Rearrenge InfoHeader buttons * Refactor: Added new component for updated InfoHeader * chore: flex removal * chore: Rabbit suggestions * chore: Made suggested changes * chore: Verbiage alignment * fix: BED-6971 Added error handling for Prefer header in POST /api/v2/custom-nodes BED-6971 (#2166) * bug: BED-6971 added error handling to only accept blank or valid values for prefer header * bug: BED-6971 Fixed Schema to show default field in UI. BED-6971 * bug: BED-6971 Modified middleware_internal_test.go to support new validation. BED-6971 * feat: Retrieve All Results from Environments Table BED-6858 (#2153) * feat(OpenGraph): Add schema findings migrations BED-6751 * feat: retrieve all schema environments from database - has some IP work from Conrad's tickets as well * another test * feat: just prepare * feat(OpenGraph): Add schema findings migrations BED-6751 * fixed model and regenerated mocks * grabbed Conrad's most recent schema changes * conflicts * merge pains * using embedded serial instead of just id * CreateSchemaEnvironment tests * fixed my test check --------- Co-authored-by: Conrad Weidenkeller <[email protected]> * chore: Generate Allure Test Results via GH Actions BED-6561 (#2162) * fix upload artifacts naming collision * remove the whilecard * fix: don't output passwords to log file when configured via env/config file - BED-6952 (#2156) * fix: don't log/generate admin passwords when already set via env or config Closes: #161 * chore: fix typo * chore: prepare-for-codreview * chore: fix package * chore: Deploy Allure Test Result on GH Pages BED-6993 (#2168) * chore: Deploy Allure Test Result on GH Pages BED-6993 closes: BED-6993 * test allure report generation on BED-6693 branch * update the branch * remove BED-6993 branch * ping 3rd party gh action v4 sha * fix(OpenGraph): Ensure v8.5.0 Open Graph Schema Migration is Idempotent - BED-7035 (#2173) * fix: autocomplete tooltip positioning in saved query dialog BED-7043 (#2182) * refactor(ContextMenu): re-org asset group item logic BED-6970 (#2154) * refactor(ContextMenu): regorg asset group item logic BED-6970 * test: Update tests * CodeRabbit suggestions * Use existing self mock * Use shared consts * refactor: extract asset group tag type logic * refactor: use cleaner patterns * chore: remove vestigial test data * replace any type * move query and update tests * fix: swapped detail link types * Use name Rule instead of Selector * update comments * rename * chore: BED-6943 (#2167) * wip: adding etac filtering to SearchHandler * chore: current unit tests work * chore: added unit tests for coverage * chore: adding some comments * chore: adding test case for user with all_env = true * chore: remove duplicate test * chore: fixing comments left on pr * chore: update comment * chore: updated comment * chore: cleaning up the var section * chore: changing GetUserFromAuthCtx return error to http.StatusBadRequest * refactor(API migrations): Enables "analysis.citrix_rdp_support" BED-6392 (#2180) * Refactor(API migrations): Enables "analysis.citrix_rdp_support" in parameters database table to true - Sets "analysis.citrix_rdp_support" row from "key" column in parameters database table to "enabled: true" in the "value" column closes BED-6392 * refactor(API migrations): Enables "analysis.citrix_rdp_support" in parameters database table to true - Sets "analysis.citrix_rdp_support" row from "key" column in parameters database table to "enabled: true" in the "value" column closes BED-6392 * - takes out unnecessary updated_at field value change in parameters table * - delete trailing comma from last commit * fix: fixed label count BED-6957 (#2176) * BED-6957 fixed label count * PR feedback * fix: Codemirror tooltip positioning bug BED-7038 (#2181) * add class selector to prevent tooltip positioning bug * updated test constants * fix: positioning of save query confirmation modal BED-7041 (#2183) * fix: refactor save query confirmation to use DoodleUI BED-7041 * BED-7041 - desc color * feat(PZ): API - Add Kind filtering to asset-group-tags/{%s}/selectors/{%s}/members BED-6820 (#2164) * feat(PZ): API - Add Kind filtering to asset-group-tags/{%s}/selectors/{%s}/members * Updated OpenAPI Docs * Added more API test cases * Addressed PR feedback * Addressed PR feedback again * Got tests to pass again * feat: make table view sort arrows always visible BED-7002 (#2178) * BED-7002 - table view arrows visible * BED-7002 - add unit test * BED-7002 - add additional tests * BED-7002--sort arrows to be consistent with other cmps, dark mode color * BED-7002 - smaller arrows * BED-7002 - arrows always use active color * BED-7002 - update unit tests * chore: Zone Icon consistency BED-6924 (#2171) * chore:BED-6924 aligned/sized with notes * chore:BED-6924 remove stroke in DataAlert, remove height/width in Disabled, cleanup Taglist/ZoneIcon * chore:BED-6924 add license to ZoneIcon / remove ZoneAnalysisIcon * chore:BED-6924 small style adjustment * chore:BED-6924 remove comments * chore:BED-6924 only display disabled or upgrade zone Icon for TagList * chore:BED-6924 add persistGlyph prop to ZoneIcon for use in DynamicDetails, add case for hygiene,update styles * chore:BED-6924 clean up/add pick to ZoneIcon type * chore:BED-6924 add hygiene id to ZoneIcon, add size prop to DynammicDetails * chore:BED-6924 small logic change in ZoneIcon * chore:BED-6924 remove isZonePage, clean up ZoneIcon * chore:BED-6924 update styling * feat: Source Kind Deactivation instead of Deletion + Source Kind Registration / Re-activation BED-6939 BED-6913 (#2165) * feat: modified delete source kinds to deactivate source kinds by adding an active field on the source_kinds table, also modified the methods needed to register, retrieve, and deactivate a source kind * just prepare * added a couple more integration tests * woopsie poopsie * annoying lil line snuck in * addressed some things I overlooked with tests * wow coderabbit caught me again * feat: modified DeactivateSourceKindsByName to no longer allow user to deactivate source kinds that are AZBase or Base, added more integration tests to reflect this change * one more flaw in existing tests fixed, ready for re-review * final address coderabbit * source kinds returned in deterministic order + updated tests to reflect the change * feat(OpenGraph): Add API endpoint to get OpenGraph edge kinds BED-6708 (#2179) * add api to get edge kinds * add tests * generate mocks * fix pointer dereference * rabbit suggestions * rabbit suggestions * fix failing test * fix test * fix verb in test string * better test case for empty response * move feature flag check to the router * translate query filters in new struct * refactor: Change displayed title for Privilege Zones view BED-7030 (#2196) * refactor: Change displayed title for Privilege Zones view * test: Updated test to cover title change * feat(PZ): API - Add asset group tag id Filtering to Global Search BED-6847 (#2197) * feat(PZ): API - Add asset_group_tag_id filtering to global search * Added another api test case * fix: finally got all tests to pass * Updated Open API docs * Addressed PR feedback * Addressed more PR feedback * feat: "Run" button 'running' status - BED-6992 (#2077) * add simple status timeout to run query button * add cancel functionality to cypher serch button * adjust messageing to use CypherSearchMessage component * hook message aimation to animation timeouts * move animation logic back to CypherSearchMessage component * add simple success state * adjust props for cypher message test * move icons * add ProcessingIndicator to cypher search * restore prop requirement * remove onSuccess and onError callbacks from CypherSearch * restore label to button * remove unused logic * remove cancellation from run button * update run button copy * restore performSearch functionality * remove unused vars * restore performsearch function --------- Co-authored-by: Amin Yaßin <[email protected]> Co-authored-by: Elijah Brown <[email protected]> Co-authored-by: Wes <[email protected]> Co-authored-by: Ben Waples <[email protected]> Co-authored-by: Siri <[email protected]> Co-authored-by: Ulises Rangel <[email protected]> Co-authored-by: Michael Smith <[email protected]> Co-authored-by: Lawson Willard <[email protected]> Co-authored-by: Alyx Holms <[email protected]> Co-authored-by: Raymond Laubert <[email protected]> Co-authored-by: Flechas Bentley <[email protected]> Co-authored-by: Leah Miller <[email protected]> Co-authored-by: Ibrahim Useinovski <[email protected]> Co-authored-by: Irshad Ajmal Ahmed <[email protected]> Co-authored-by: Lucas Parra <[email protected]> Co-authored-by: Benjamin Sheth <[email protected]> Co-authored-by: Benjamin Sheth <[email protected]> Co-authored-by: Katherine Powderly <[email protected]> Co-authored-by: Flechas Bentley <[email protected]> Co-authored-by: Catherine Siller <[email protected]> Co-authored-by: ykaiboussiSO <[email protected]> Co-authored-by: Arianna Cooper <[email protected]> Co-authored-by: Dani Cairns <[email protected]> Co-authored-by: Conrad Weidenkeller <[email protected]> Co-authored-by: Dillon Lees <[email protected]> Co-authored-by: Conrad Weidenkeller <[email protected]> Co-authored-by: Rohan Vazarkar <[email protected]> Co-authored-by: Fernando Pena <[email protected]> Co-authored-by: Katie Strader <[email protected]> Co-authored-by: Sem Limi <[email protected]> Co-authored-by: Wesley Maffly-Kipp <[email protected]> Co-authored-by: Jeff Vacca <[email protected]>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
specter-flq
changed the title
elikmiller
force-pushed
the
stage/v8.4.2
branch
from
f4bbe44 to
767cf6e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to resolve merge conflicts between main and stage/v8.4.2
Motivation and Context
Resolves BED-6953
How Has This Been Tested?
Screenshots (optional):
Types of change
Checklist: