Skip to content

Conversation

weiglszonja
Copy link

@weiglszonja weiglszonja commented May 13, 2025

This PR introduces a standalone script (fix_openephys_xml_missing_channels.py) that:

  • Issues a warning when missing channels are detected in the XML (based on the CHANNELS tag)
  • Fills in missing channels in the CHANNELS, ELECTRODE_XPOS, and ELECTRODE_YPOS tags using inferred values
  • Optionally overwrites the original XML or saves a corrected copy (.fixed.xml).

See example for dataset in catalystneuro/schneider-lab-to-nwb#33

@weiglszonja weiglszonja marked this pull request as draft May 13, 2025 16:06
@weiglszonja weiglszonja marked this pull request as ready for review May 14, 2025 13:25
@weiglszonja
Copy link
Author

@h-mayorquin @alejoe91 let me know what you think

@samuelgarcia
Copy link
Member

Hi Szonja.
Ok for me.
Would it be possible to add a bit more context doc in the docstring of the function to explain the kind of bugs expected and maybe which version could be affected ?

@weiglszonja
Copy link
Author

Hi Szonja. Ok for me. Would it be possible to add a bit more context doc in the docstring of the function to explain the kind of bugs expected and maybe which version could be affected ?

Thanks, I agree. I'll add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants