-
Notifications
You must be signed in to change notification settings - Fork 55
WIP: Named pipes for closing the app #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This is rad! |
👍 |
|
@rzhw Any further progress on this ? :) |
@peters I haven't had much time recently, but I was previously thinking about how to best deal with a timeout e.g. whether to create a new view, how to present the UI, etc etc. Thanks for the reminder, I'm thinking now it might be better to get this PR up to something working and ready to be merged in first |
I'll pare this PR's scope down to providing the listen for exit method + the uninstaller making use of it. If the app doesn't listen for exit, or the request to exit times out, it'll just fall back onto the current behaviour of delete on restart; anything more could be added later if this is merged |
Use GitHub url for UpdateManager
Having a go at #186, though the PR right now is incomplete.
Biggest issue is that I haven't worked out how to confirm whether my setup.exe is using my local build of Squirrel or the one inNeed to have tools dir updated Otherwise, the code needs tidying up. Also testspackages
, so I'm not sure if the code I put in uninstall actually runs.I've dropped this into a clone of Shimmer.Samples and so far can get it to compile
, and tell it to close with a separate command line app (source), as well as with this in AppBootstrapper.cs:or
This PR description needs cleaning up. List:
[ ] Uninstaller should ask retry/continue/cancel if exit request times out[ ] What if the app is running but doesn't receive exit request in time? (Does the named pipe client instantly know if the server is running - maybe assume if it's up then the app is running)