Skip to content

Conversation

guzzijones
Copy link
Contributor

fix integration test by deleting queues before test starts.

@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. size/M PR that changes 30-99 lines. Good size to review. size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/S PR that changes 10-29 lines. Very easy to review. size/M PR that changes 30-99 lines. Good size to review. labels Sep 17, 2025
@guzzijones
Copy link
Contributor Author

so i am behind a proxy. pants doesn't play well. I can't update lock files.

@guzzijones
Copy link
Contributor Author

I also got rid of 3.8 and 3.9 testing. 3.9 is eol in October. I also swapped jsonpath-rw for jsonpath-ng

@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/L PR that changes 100-499 lines. Requires some effort to review. labels Sep 17, 2025
@guzzijones
Copy link
Contributor Author

nevermind on jsonpath-rw the changes. i will just do the bare minimum

@nzlosh
Copy link
Contributor

nzlosh commented Sep 17, 2025

We still support rocky8 and ubuntu20.04 which are still on py3.9 last time I checked. Unless there are newer python versions for these distros dropping py3.9 will be premature for the st2 v3.9 release.

@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Sep 18, 2025
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so i am behind a proxy. pants doesn't play well. I can't update lock files.

If needed, I can regen for you and push to your branch.

@guzzijones
Copy link
Contributor Author

Ok. i think this is ready for a pants update. error is related to

stderr:
There was 1 error downloading required artifacts:
1. st2-rbac-backend 3.9.dev0 from git+https://github.com/StackStorm/st2-rbac-backend.git@master
   Expected sha256 hash of d34d5cbb539182553ec8b35a0763decb6b66bd37aa51f3a61db1eb30449f6f10 when downloading st2-rbac-backend but hashed to f445faec6e5f55437f379be08dd78aa2f1181ed9dbd04fe19bddfb6f4c2fe911.```

I am guessing that hash is in the lock files.

@cognifloyd
Copy link
Member

I'm writing a GHA workflow to, on demand, regenerate lockfiles and push a commit to the selected PR.

@guzzijones
Copy link
Contributor Author

guzzijones commented Sep 19, 2025

The st2 self check is failing.

  stdout: ''
Registering content...[flags = --config-file /home/runner/work/st2/st2/conf/st2.ci.conf --register-all]
/home/runner/work/st2/st2/virtualenv/bin/st2-register-content:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  __import__('pkg_resources').require('st2common==3.9.dev0')
Traceback (most recent call last):
  File "/home/runner/work/st2/st2/virtualenv/bin/st2-register-content", line 4, in <module>
    __import__('pkg_resources').require('st2common==3.9.dev0')
  File "/home/runner/work/st2/st2/virtualenv/lib/python3.10/site-packages/pkg_resources/__init__.py", line 3673, in <module>
    def _initialize_master_working_set():
  File "/home/runner/work/st2/st2/virtualenv/lib/python3.10/site-packages/pkg_resources/__init__.py", line 3656, in _call_aside
    f(*args, **kwargs)
  File "/home/runner/work/st2/st2/virtualenv/lib/python3.10/site-packages/pkg_resources/__init__.py", line 3685, in _initialize_master_working_set
    working_set = _declare_state('object', 'working_set', WorkingSet._build_master())
  File "/home/runner/work/st2/st2/virtualenv/lib/python3.10/site-packages/pkg_resources/__init__.py", line 661, in _build_master
    ws.require(__requires__)
  File "/home/runner/work/st2/st2/virtualenv/lib/python3.10/site-packages/pkg_resources/__init__.py", line 1070, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/home/runner/work/st2/st2/virtualenv/lib/python3.10/site-packages/pkg_resources/__init__.py", line 897, in resolve
    dist = self._resolve_dist(
  File "/home/runner/work/st2/st2/virtualenv/lib/python3.10/site-packages/pkg_resources/__init__.py", line 938, in _resolve_dist
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'oslo.serialization>=1.10.0' distribution was not found and is required by tooz

@guzzijones
Copy link
Contributor Author

I think this is called 2 times
[CI / Self-check on Python 3.10

I see it was also successful
Test / Self-Check - Python 3.10 (pull_request)Successful in 8m

Is there a race condition happening here?

@guzzijones
Copy link
Contributor Author

I definitively reproduced it locally.

@guzzijones
Copy link
Contributor Author

This should be good to go now. just one final test that kills rabbitmq sometimes. @cognifloyd @nzlosh

@cognifloyd
Copy link
Member

@guzzijones, now that #6356 is in--fixing a lot of other CI issues--I would love to get the queue deletion fix in. Could you remove the other things from this PR so it focuses only on the integration test improvement?

The other changes might also be good, though some probably need to wait until after st2 3.9 is released. These improvements would be make great additional PRs:

  • drop py3.8 (this will involve changes across multiple repos)
    • this will probably include upgrading setuptools and cryptography.
  • remove PY3 check from legacy dist_utils.py files
  • Use pip install -e instead of setup.py develop everywhere (at least in Makefile and scripts/github/prepare-intgration.sh)

@guzzijones
Copy link
Contributor Author

guzzijones commented Oct 4, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L PR that changes 100-499 lines. Requires some effort to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants