-
-
Notifications
You must be signed in to change notification settings - Fork 771
delete queues for integration #6354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
so i am behind a proxy. pants doesn't play well. I can't update lock files. |
I also got rid of 3.8 and 3.9 testing. 3.9 is eol in October. I also swapped jsonpath-rw for jsonpath-ng |
6499daf
to
f43270e
Compare
nevermind on jsonpath-rw the changes. i will just do the bare minimum |
We still support rocky8 and ubuntu20.04 which are still on py3.9 last time I checked. Unless there are newer python versions for these distros dropping py3.9 will be premature for the st2 v3.9 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i am behind a proxy. pants doesn't play well. I can't update lock files.
If needed, I can regen for you and push to your branch.
Ok. i think this is ready for a pants update. error is related to
|
I'm writing a GHA workflow to, on demand, regenerate lockfiles and push a commit to the selected PR. |
The st2 self check is failing.
|
I think this is called 2 times I see it was also successful Is there a race condition happening here? |
I definitively reproduced it locally. |
This should be good to go now. just one final test that kills rabbitmq sometimes. @cognifloyd @nzlosh |
@guzzijones, now that #6356 is in--fixing a lot of other CI issues--I would love to get the queue deletion fix in. Could you remove the other things from this PR so it focuses only on the integration test improvement? The other changes might also be good, though some probably need to wait until after st2 3.9 is released. These improvements would be make great additional PRs:
|
I will just make a new pr with the queue deletion fix. this one can have a
conflict and I will fix that later. I will do it Monday.
…On Wed, Oct 1, 2025 at 6:26 PM Jacob Floyd ***@***.***> wrote:
*cognifloyd* left a comment (StackStorm/st2#6354)
<#6354 (comment)>
@guzzijones <https://github.com/guzzijones>, now that #6356
<#6356> is in--fixing a lot of
other CI issues--I would love to get the queue deletion fix in. Could you
remove the other things from this PR so it focuses only on the integration
test improvement?
The other changes might also be good, though some probably need to wait
until after st2 3.9 is released. These improvements would be make great
additional PRs:
- drop py3.8 (this will involve changes across multiple repos)
- this will probably include upgrading setuptools and cryptography.
- remove PY3 check from legacy dist_utils.py files
- Use pip install -e instead of setup.py develop everywhere (at least
in Makefile and scripts/github/prepare-intgration.sh)
—
Reply to this email directly, view it on GitHub
<#6354 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZ5TIOXUND2VGCM435EOJL3VRIKHAVCNFSM6AAAAACGZAV5KOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNJYGM3TANJUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fix integration test by deleting queues before test starts.