-
Notifications
You must be signed in to change notification settings - Fork 171
Expose secure/non-secure URIs on service instance, optimize Eureka #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary - All Code Coverage (ubuntu-latest)
|
c4ce8a3 to
99b0cba
Compare
|
TimHess
reviewed
Oct 1, 2025
bart-vmware
commented
Oct 2, 2025
TimHess
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component/Discovery
Issues related to Steeltoe Service Discovery
.NET Aspire
ReleaseLine/4.x
Identified as a feature/fix for the 4.x release line
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
This PR adds two new nullable properties to
IServiceInstance:SecureUriandNonSecureUri.They are populated for Eureka, because such an instance can contain both.
Furthermore, internal storage for secure/non-secure Eureka VIP addresses has been combined into a single collection, which reduces the need for copying collections. Locking was removed to improve throughput, which comes at the cost of a small increase in memory usage: when all instances of a service are removed, an empty instance collection is kept in memory.
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.