-
Notifications
You must be signed in to change notification settings - Fork 171
Fix actuators when used with UsePathBase #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary - All Code Coverage (ubuntu-latest)
|
src/Management/src/Endpoint/ConfigureActuatorsMiddlewareStartupFilter.cs
Show resolved
Hide resolved
TimHess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the wording on this warning, otherwise LGTM
src/Management/src/Endpoint/ConfigureActuatorsMiddlewareStartupFilter.cs
Outdated
Show resolved
Hide resolved
src/Management/test/Endpoint.Test/Actuators/All/AllActuatorsTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Hess <[email protected]>
cf31edb to
d7f634d
Compare
|
TimHess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



Description
Applies
HttpContext.Request.PathBasewhen rendering hypermedia links. Logs a warning when middleware is registered multiple times. RemovesPathBasefrom the URL being passed to actuator handlers, so that internal checks work properly whenUsePathBaseis used.Fixes #1617.
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.