-
Notifications
You must be signed in to change notification settings - Fork 171
Fix gcdump publish and transitive references #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested with the following project, which contains a web api that references a class library that references a local Steeltoe NuGet package. Includes scripts to build fresh Steeltoe packages and copy them to the local directory, while clearing the global NuGet cache. Unzip into a sibling directory of Steeltoe. Build/run and use the .http file to download a gcdump. Before trying, you may need to adjust the paths in the scripts and create the PackagesFromSteeltoe sibling directory upfront. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses issue #1612 by fixing how dotnet-gcdump is published in the Steeltoe.Management.Endpoint NuGet package and resolving transitive reference issues with Microsoft.Diagnostics.FastSerialization. The changes consolidate the packaging logic into the main project file and downgrade Microsoft.Diagnostics.Tracing.TraceEvent to ensure binary compatibility.
Key Changes:
- Downgraded Microsoft.Diagnostics.Tracing.TraceEvent from version 3.1.26 to 3.1.23 for binary compatibility
- Removed the separate Build/Steeltoe.Management.Endpoint.props file that consumers would import
- Added an MSBuild target to embed dotnet-gcdump.dll directly in the NuGet package for each target framework
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| versions.props | Downgrades Microsoft.Diagnostics.Tracing.TraceEvent to 3.1.23 for binary compatibility with FastSerialization |
| Steeltoe.Management.Endpoint.csproj | Consolidates gcdump reference logic, removes FastSerialization reference, adds custom packing target |
| Build/Steeltoe.Management.Endpoint.props | Removes external props file that was distributed to package consumers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@bart-vmware I've opened a new pull request, #1620, to work on those changes. Once the pull request is ready, I'll request review from you. |
Summary - All Code Coverage (ubuntu-latest)
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|



Description
Fixes #1612.
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.