Skip to content

Conversation

@bart-vmware
Copy link
Member

Description

Fixes #1612.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware
Copy link
Member Author

bart-vmware commented Nov 19, 2025

Tested with the following project, which contains a web api that references a class library that references a local Steeltoe NuGet package. Includes scripts to build fresh Steeltoe packages and copy them to the local directory, while clearing the global NuGet cache. Unzip into a sibling directory of Steeltoe. Build/run and use the .http file to download a gcdump.

Before trying, you may need to adjust the paths in the scripts and create the PackagesFromSteeltoe sibling directory upfront.

SteeltoePackageTest.zip

@bart-vmware bart-vmware marked this pull request as ready for review November 19, 2025 17:01
Copilot finished reviewing on behalf of bart-vmware November 19, 2025 17:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #1612 by fixing how dotnet-gcdump is published in the Steeltoe.Management.Endpoint NuGet package and resolving transitive reference issues with Microsoft.Diagnostics.FastSerialization. The changes consolidate the packaging logic into the main project file and downgrade Microsoft.Diagnostics.Tracing.TraceEvent to ensure binary compatibility.

Key Changes:

  • Downgraded Microsoft.Diagnostics.Tracing.TraceEvent from version 3.1.26 to 3.1.23 for binary compatibility
  • Removed the separate Build/Steeltoe.Management.Endpoint.props file that consumers would import
  • Added an MSBuild target to embed dotnet-gcdump.dll directly in the NuGet package for each target framework

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
versions.props Downgrades Microsoft.Diagnostics.Tracing.TraceEvent to 3.1.23 for binary compatibility with FastSerialization
Steeltoe.Management.Endpoint.csproj Consolidates gcdump reference logic, removes FastSerialization reference, adds custom packing target
Build/Steeltoe.Management.Endpoint.props Removes external props file that was distributed to package consumers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Nov 19, 2025

@bart-vmware I've opened a new pull request, #1620, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions
Copy link
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 85.6% 80.6%
Steeltoe.Common.Certificates 96.2% 85.5%
Steeltoe.Common.Hosting 84% 70%
Steeltoe.Common.Http 100% 85.2%
Steeltoe.Common.Logging 81.1% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 98.5% 91.1%
Steeltoe.Configuration.CloudFoundry 99.1% 91.8%
Steeltoe.Configuration.ConfigServer 97.2% 91.6%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.3% 95%
Steeltoe.Connectors 93.9% 89.8%
Steeltoe.Connectors.EntityFrameworkCore 81.5% 75%
Steeltoe.Discovery.Configuration 92.3% 100%
Steeltoe.Discovery.Consul 98.1% 94.8%
Steeltoe.Discovery.Eureka 91.8% 85.2%
Steeltoe.Discovery.HttpClients 94.2% 95.4%
Steeltoe.Logging.Abstractions 99.4% 96.9%
Steeltoe.Logging.DynamicConsole 100% 95.4%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.5% 89.2%
Steeltoe.Management.Prometheus 95.9% 91.6%
Steeltoe.Management.Tasks 100% ****
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 100%
Steeltoe.Security.Authentication.OpenIdConnect 73.8% 59%
Steeltoe.Security.Authorization.Certificate 96.3% 75%
Steeltoe.Security.DataProtection.Redis 100% ****

This comment was marked as off-topic.

@bart-vmware bart-vmware requested a review from TimHess November 19, 2025 18:38
@sonarqubecloud
Copy link

@bart-vmware bart-vmware merged commit ac04a11 into main Nov 20, 2025
28 of 31 checks passed
@bart-vmware bart-vmware deleted the fix-refs branch November 20, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception on gcdump from published app

3 participants