Fix citation collection link #638
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to link citations to collections during entry processing. The main purpose is to automatically establish citation-collection relationships based on entry data, both during automated submission processing and via a dedicated batch command.
- Extends the auto-processing logic to attach citations to collections in addition to molecules
- Introduces a new console command to retroactively link existing citations to collections
- Implements batch processing with progress tracking for efficient handling of large datasets
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| app/Console/Commands/SubmissionsAutoProcess/ImportEntriesReferencesAuto.php | Adds logic to attach citations to collections when processing entry references, mirroring the existing molecule citation attachment |
| app/Console/Commands/LinkCitationsCollections.php | New command that batch-processes entries to establish citation-collection relationships for existing data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| public function handle() | ||
| { | ||
| $doiRegex = '/\b(10[.][0-9]{4,}(?:[.][0-9]+)*)\b/'; |
There was a problem hiding this comment.
The $doiRegex pattern defined at line 18 is simpler than the pattern in extract_dois at line 134. This inconsistency could lead to different matching behavior. Consider using the same regex pattern or extracting it as a class constant to ensure consistency.
No description provided.