Skip to content

Conversation

YaxitaAmin
Copy link

@YaxitaAmin YaxitaAmin commented Jun 26, 2025

Related Issue
Fixes #660

Description of Changes

  • Added robust dark theme detection using CSS classes, data attributes, media queries, and CSS variables, with real-time updates via MutationObservers and event listeners.
  • Imported and applied ag-theme-alpine-dark stylesheet to support dark mode styling in the grid.
  • Enhanced cell, header, and row styling to dynamically adapt to light and dark themes, including alternating row colors and improved no-data state visuals.
  • Improved performance by memoizing column definitions and row data processing with useMemo, and stabilizing functions with useCallback.
  • Added advanced column filter options and grid features such as range selection and popup handling for better usability.
  • Refactored component structure for better readability, maintainability, and flexibility.
  • Ensured columns auto-size correctly on grid initialization and theme changes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing

tested.mp4

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run my code against examples and ensured no errors
  • Any dependent changes have been merged and published in downstream modules

- Enhanced dark theme detection with multiple fallbacks
- Added CSS custom properties for consistent theming
- Improved alternating row styling for both themes
- Added proper header styling and no-data state
- Performance optimizations with useMemo and useCallback
- Real-time theme switching support

Fixes StructuredLabs#660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dark Theme is not getting applied to all the elements
1 participant