Skip to content

fix (build) : Fixes build error due to 2GB default memory allocation to v8 engine (nodejs) #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix (build) : Fixes build error due to 2GB default memory allocation to v8 engine (nodejs) #776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
916a92f
Set NODE_OPTIONS environment variable for npm commands
vineetbambah Aug 21, 2025
727abea
pass the updated environment to the _run_npm_command function
vineetbambah Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion preswald/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
"""Build utilities for preswald."""

import os
import shutil
import subprocess
import sys
from pathlib import Path


env = os.environ.copy()
env["NODE_OPTIONS"] = env.get("NODE_OPTIONS", "--max-old-space-size=4096")


def _run_npm_command(cmd: str, cwd: Path) -> int:
"""Run an npm command in the specified directory."""
npm_path = shutil.which("npm")
if not npm_path:
print("Error: npm not found. Please install npm first.", file=sys.stderr)
return 1

result = subprocess.run([npm_path, *cmd.split()], cwd=cwd, check=False)
result = subprocess.run([npm_path, *cmd.split()], cwd=cwd, check=False, env=env)
return result.returncode


Expand Down