Added color saturation slider #3251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really appreciate the work on this PR as it would fix #3128 (which, believe it or not, has bothered me a lot when creating backgrounds) |
|
Thanks for your contribution! Before we proceed reviewing this, can you remove any unrelated files from the tree (including log files, exe outputs, etc.)? Also, please add a new line to all those files that don't have one at the end of the file. |
|
It also seems like these files have been changed to CRLF. Here we use LF line endings, so please configure your editor properly. |
|
Addressed feedback: removed extra files and (I think) fixed line endings to LF |
tobbi
reviewed
Apr 26, 2025
tobbi
reviewed
Apr 26, 2025
| } | ||
|
|
||
| /* EOF */ | ||
| /* EOF */ |
tobbi
reviewed
Apr 26, 2025
| #endif | ||
|
|
||
| /* EOF */ | ||
| /* EOF */ |
|
are there plans on updating this based on tobbi's review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a school project, my friend and I have worked on a solution for a color saturation slider that was proposed and discussed as a listed issue. Even if it is unacceptable, we would greatly appreciate any comments. Thank you.
Fixes #3128