Skip to content

Conversation

huntekye
Copy link
Contributor

@huntekye huntekye commented Sep 5, 2025

Also, add placeholder graphics, and make it available in bonus blocks.

I would love to get rid of the nested ternary operators if possible, let me know if you have any suggestions.

Also just let me know if there are any variable names / code quality things you want changed, or feel free to change them yourself.

Also, add placeholder graphics, and make it available in bonus blocks
@Hypernoot
Copy link
Member

So basically an enemy inside a bonus block.

@huntekye
Copy link
Contributor Author

huntekye commented Sep 7, 2025

No, that was considered, but the behavior here is intentionally distinct. If it were an enemy, it wouldn't disappear after hurting Tux, and it would be possible to kill it without being damaged, but this is a moving obstacle that can only be avoided. It might also have distinct physics, if the normal egg gets updated with new physics.

Oh and I forgot to mention, there is currently a small bug: if big Tux is standing still when the rotten egg hits him, then sometimes he will shrink and be displaced down one tile without his sprite being updated to small Tux. It doesn't happen when moving, and when standing still it only lasts until Tux begins moving or his idle animation starts, so I think there just needs to be an extra line in the GrowUp's collision function to force the sprite to be updated, but idk how that would happen.

Improved badegg sprite by Frostwithasideofsalt
Fix the initialization list/member variables in GrowUp
Change the nested ternary operators to chained ternary operators
Make a Rotten Egg bonus block tile available in the editor
@huntekye
Copy link
Contributor Author

huntekye commented Sep 9, 2025

Okay, I think this is basically ready, except I still don't know why a rotten egg landing on a big Tux standing still pushes Tux into the ground, i.e. changes Tux's hitbox without updating the sprite.

@huntekye huntekye marked this pull request as ready for review September 9, 2025 19:38
@korbanpapa
Copy link

Ok so, maybe i don't understand this completely, but does this basically act like the poison mushroom from super mario brothers? if so, what's the gameplay for this going to look like? is it going to give you coins when you get another powerup afterwards, or just hurt you? genuinely wanting to know.

@huntekye
Copy link
Contributor Author

To me, it seems to mainly be to compliment the theme of the corrupted forest levels: corrupted enemies, corrupted granitos, corrupted plants, why not a corrupted powerup too? Idk what Mario's mushrooms are like, but this can be another way to increase the difficulty in the corrupted forest levels.

@Frostwithasideofsalt
Copy link
Member

Ok so, maybe i don't understand this completely, but does this basically act like the poison mushroom from super mario brothers? if so, what's the gameplay for this going to look like? is it going to give you coins when you get another powerup afterwards, or just hurt you? genuinely wanting to know.

it's just a poison mushroom, yes. it doesn't benefit the player in any way, all it does is hurt the player.

@korbanpapa
Copy link

It's a cool idea, but if it doesn't have a function besides hurting the player, i don't really see the use of adding an extra item "just because". on the other hand, if it does have a use like giving coins once you get another powerup or something like that, in that case you could try pitching it to the team for their thoughts on the matter. sorry if i'm seeming rude on this thought. :|

@Alasdairbugs
Copy link
Contributor

I don't get the whole "just because" thing, you just acknowledged it can damage the player. That's a use 🤷 so it's not a "just because" addition? Correct me if I'm wrong

Also, as an experienced level designer this definitely has more advanced uses. The power up, like existing ones, could interact with objects like a dispenser or spring or bumper, etc.

@korbanpapa
Copy link

what I'm saying is, a powerup should give some kind of boost to the player not just to hurt the player and that's it. it should help the player in some kind of way, whether that's coins, an egg, fireflower, etc... also, it's a powerUP not powerdown.

@mrkubax10 mrkubax10 added involves:functionality status:in-progress Progress has been done, but more is intended be done status:needs-discussion Team member and developers need to discuss of decisions type:feature category:code category:design labels Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code category:design involves:functionality status:in-progress Progress has been done, but more is intended be done status:needs-discussion Team member and developers need to discuss of decisions type:feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants