Improve Credits' Organization (Rebase) #3371
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frostwithasideofsalt
changed the title
tobbi
reviewed
Sep 7, 2025
| (name "Carsten \"RustyBox\" Wirtz") | ||
| (info (_ "Graphics, Level Design, Story")) | ||
|
|
||
| (person |
tobbi
reviewed
Sep 7, 2025
| (string (_ "Past Team Members")) | ||
| ) | ||
|
|
||
| (blank) |
There was a problem hiding this comment.
Can you align this part with the rest as well?
tobbi
reviewed
Sep 7, 2025
| (text | ||
| (type "normal") | ||
| (string (_ "Comments, ideas and suggestions")) | ||
| (string (_ "or share them on the Forum")) |
There was a problem hiding this comment.
Doesn't forum need to start with a lowercase letter here?
tobbi
reviewed
Sep 7, 2025
|
|
||
| (text | ||
| (type "heading") | ||
| (string (_ " Special Thanks to")) |
There was a problem hiding this comment.
Leading space before "Special". Was this intended?
|
One more thing: What about the forums? Wouldn't it make sense to keep the link? |
|
Do we want to sort by first name? I thought last name is more convenient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase of #2943