#755 Hero Buffs #1162
Open
#755 Hero Buffs #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried to replicate proposed issue, Could not replicate. If you shut down the server it would remove the Hero Buffs. Sorry @Suprcode included some more changes to this commit. 1. Hero buffs acts like Players buff on server restart/shutdown. (Retains the buffs) 2. Hero buff border to follow Official (Red border) 3. Hero Name to follow Official (Purple) 4. If you seal the Hero it will now remove the active buffs.
Suprcode
requested changes
Dec 22, 2025
Owner
Suprcode
left a comment
Suprcode
left a comment
There was a problem hiding this comment.
Strange image logic needs correcting
| _buffCount = _buffList.Count; | ||
|
|
||
| var baseImage = 20; | ||
| var baseImage = (Index >= 40 && Index <= 53) ? 40 : 20; |
Owner
There was a problem hiding this comment.
Don't understand this logic?
If there are 2 buff dialog colours, then you should have a new property that controls which one to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to replicate proposed issue, Could not replicate.
If you shut down the server it would remove the Hero Buffs. Sorry @Suprcode included some more changes to this commit.