Merge dev -> main #6
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First commit of readme file in english
Add shortcuts to sections
Remove: -Framework dependencies Add: -Spm dependencies to the project -Firebase auth initialization # Conflicts: # Project.swift # Resources/GoogleService-Info.plist # Targets/SwiftBuddiesLogin/Sources/LoginView.swift # Targets/SwiftBuddiesMain/Sources/AppMain.swift # Tuist/Package.swift
Remove: -Framework dependencies Add: -Spm dependencies to the project -Firebase auth initialization # Conflicts: # Project.swift # Resources/GoogleService-Info.plist # Targets/SwiftBuddiesMain/Sources/AppMain.swift # Tuist/Package.swift
### Issue Link 🔗 #23 ### Goals ⚽ To show the community logo in the README file ### Implementation Details 🚧 There is no architectural changes or new functionality. ### Testing Details 🔍 Reviewed Changes in Pushed Branch ### Screenshots/Gifs 📷 <img width="875" alt="Screenshot 2024-09-11 at 02 30 18" src="https://github.com/user-attachments/assets/f24721d8-852d-42bb-933d-79cb820330ab"> ## PR Type What kind of change does this PR introduce? - [x] Documentation content changes
### Issue Link 🔗 <!-- What is your redmine link for this task? --> [37](#37) [38](#38) ### Goals ⚽ <!-- List the high-level objectives of this pull request. --> <!-- Include any relevant context. --> Update userLocation and fetch eventData ### Implementation Details 🚧 <!-- Explain the reasoning behind any architectural changes. --> <!-- Highlight any new functionality. --> I resolved the user location update issue and optimized the GET request with a caching mechanism which is new in network layer. ### Testing Details 🔍 <!-- Describe what tests you've added for your changes. --> ### Screenshots/Gifs 📷 <!-- Add screenshots or Gifs when appropriate. --> <img src="https://github.com/user-attachments/assets/78b1edcb-d2a0-41a1-aebe-1f520ac88663" width="150"> ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> -[x] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [x] Other... Please describe:
### Issue Link 🔗 <!-- What is your redmine link for this task? --> ### Goals ⚽ <!-- List the high-level objectives of this pull request. --> <!-- Include any relevant context. --> Profile and profile edit page created ### Implementation Details 🚧 <!-- Explain the reasoning behind any architectural changes. --> <!-- Highlight any new functionality. --> Profile module (Profile page and profile edit page) created including API Calls ### Testing Details 🔍 <!-- Describe what tests you've added for your changes. --> ### Screenshots/Gifs 📷 <!-- Add screenshots or Gifs when appropriate. --> <img src="https://github.com/user-attachments/assets/ecbcd8ea-e2aa-4be5-ac44-7a70e4669b94" width="150"> <img src="https://github.com/user-attachments/assets/c4cb6ea7-c814-4a00-b7bd-a15d5dba22f9" width="150"> ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other... Please describe:
… deallocation of view in certain cases
Update feed views
### Issue Link 🔗 <!-- What is your redmine link for this task? --> ### Goals ⚽ <!-- List the high-level objectives of this pull request. --> <!-- Include any relevant context. --> - Update profile view to comply with app architecture ### Implementation Details 🚧 <!-- Explain the reasoning behind any architectural changes. --> <!-- Highlight any new functionality. --> - Implement navigation stack - Rearrange filesystem - Create relevant view files - Declutter views - Extract view components - Add button showcase ### Testing Details 🔍 <!-- Describe what tests you've added for your changes. --> - ### Screenshots/Gifs 📷 <!-- Add screenshots or Gifs when appropriate. --> <img src="https://github.com/user-attachments/assets/8d0ab1f3-2ef1-41f7-89be-21271baa87e9" width="150"> ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [x] Feature - [x] Code style update (formatting, renaming) - [x] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other... Please describe:
## Summary
This MR implements a modular architecture for the BuddiesIOS app using
Tuist for project generation. The modular approach divides the
application into separate concerns, enhancing maintainability,
testability, and collaboration efficiency among team members. Each
module is structured to be self-contained with clear dependencies,
promoting clean architecture principles.
## Relevant domains
- Architecture
- Project Structure
- Dependency Management
## Structure
The modular architecture is implemented using the following key
components:
- Created modular framework structure with the following modules:
- `Auth`: Authentication functionality
- `Contributors`: GitHub contributors display
- `Core`: Core application features and dependency container
- `Design`: UI components and design system
- `Feed`: Social feed functionality
- `Localization`: Localization resources
- `Network`: Networking layer
Dependencies between modules are clearly defined, with each module
specifying its dependencies in the `Project.swift` file. The
architecture follows a clean dependency graph to prevent circular
dependencies.
```mermaid
graph TD
A[App] --> B[Core]
A --> C[Design]
A --> D[Auth]
A --> E[Contributors]
A --> F[Feed]
B --> D
B --> G[Network]
C --> H[Localization]
E --> B
E --> C
F --> B
F --> C
G --> I[BuddiesNetwork]
D --> G
```
Each module is configured using the `Project.module` extension that
standardizes the module creation process, including:
- Consistent naming conventions
- Common deployment targets
- Resource management
- Module dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.