update CallableFieldType to work with services #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian-Merle
force-pushed
the
callable-field-handle-services
branch
2 times, most recently
from
bf62bf9 to
bc2ec09
Compare
Florian-Merle
force-pushed
the
callable-field-handle-services
branch
4 times, most recently
from
a7298a6 to
bab2601
Compare
Florian-Merle
force-pushed
the
callable-field-handle-services
branch
from
bab2601 to
b0e62ab
Compare
Contributor
Author
|
To make the CI green, I added a 100 limit option for the author grid. Otherwise, not all nationalities for every user were showing (the behavior was random and dependent on the fixtures). |
GSadee
approved these changes
Oct 8, 2025
Member
|
Thank you @Florian-Merle! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uptdate the CallableFieldType so it can be used with services.
Available services are the one tagged with
sylius.grid_field_callable_service.The documentation for this can be found in the second commit of this PR Sylius/Stack#245