Skip to content

feat: declare strict types and support php 8.4 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: declare strict types and support php 8.4 #205

wants to merge 1 commit into from

Conversation

@shakaran
Copy link

Applied rules:

DeclareStrictTypes

ReadOnlyProperty

ReadOnlyClass

CatchExceptionNameMatchingType

FlipTypeControlToUseExclusiveType

AddOverrideAttributeToOverriddenMethods

AddClosureVoidReturnTypeWhereNoReturn

RemoveEmptyClassMethod

RemoveUnusedConstructorParam

sadikoff
sadikoff suggested changes May 27, 2025
View reviewed changes
Copy link

@sadikoff sadikoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow nice strict types is always great, however I can't fully agree with use statements for global namespace classes, I'd prefer to keep them like \Exeption() in the code, it's easier to understand which exact Exception are you using

@shakaran shakaran mentioned this pull request May 28, 2025
Open
@shakaran
Copy link
Author

Closing this in favour of #206 with the changes requested.

@shakaran shakaran closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sadikoff sadikoff sadikoff requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shakaran @sadikoff