Skip to content

Conversation

YoshiRulz
Copy link
Member

@YoshiRulz YoshiRulz commented May 24, 2025

...and prepare for #1399. To finish that I just need to figure out where TAStudio would get called into when buttons are pressed, since that's normally handled via InputManager I believe, and then call TAStudio.TasView_ColumnClick(null, new() { Column = new() { Name = button } }) or w/e.

@YoshiRulz YoshiRulz requested a review from vadosnaprimer May 24, 2025 21:31
@Morilli

This comment was marked as outdated.

@YoshiRulz

This comment was marked as outdated.

@YoshiRulz YoshiRulz marked this pull request as ready for review September 24, 2025 20:22
@SuuperW
Copy link
Contributor

SuuperW commented Sep 28, 2025

Reduce enumerations of selection in TAStudio.TasView_ColumnClick

I do not think you actually did this. There seem to be two immediately before this commit and two immediately after. Before: foreach and then Count. After: ToArray and then foreach. (And 1 enumeration in master, 3 in this branch) But I guess it's still an improvement since iterating over the array should be faster than the InputRoll re-constructing the rows based on individual cells?

But, this seems fine anyway. Toggling a button on 1,000,000 rows is faster than actually selecting them in the first place.

@YoshiRulz YoshiRulz added this to the 2.11.1 milestone Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants