Add 64-bit-wide peeking and watches #4355
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morilli
reviewed
Jun 18, 2025
| { | ||
| _type = WatchDisplayType.Unsigned; | ||
| _type = validTypes.Count is 0 ? WatchDisplayType.Unsigned : validTypes[1]; |
There was a problem hiding this comment.
Typo? Should be validTypes[0] instead? Also the above switch should probably include WatchSize.QWord now.
There was a problem hiding this comment.
gdi Lua rewiring my brain
Morilli
reviewed
Jun 18, 2025
| if (_settings.CheckMisAligned) | ||
| var addr = watch.Address; | ||
| yield return addr; | ||
| if (_settings.CheckMisAligned) continue; // I guess we're assuming the other parts of the address are also in `_watchList`? --yoshi |
There was a problem hiding this comment.
Right... if you have a better idea for how to implement this in a simple way without getting duplicates feel free to do that here.
There was a problem hiding this comment.
Caller can Distinct(), but I didn't bother looking for where the caller(s) are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested. I just wanted to know precisely what changes would be required for this feature.
resolves #4353