Pullreq/commandline2 #416
Open
Pullreq/commandline2 #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying any options on the command line besides the ROM dump aborts with "Unknown option <--option-name>". This happened after starting the GTK application, which wants to parse the command line again. Install an empty command-line signal handler into the GTK application, since options are already parsed by CommandLine::parse(). Setting .nds_filename was alredy done by CommandLine::parse(), too, so the signal handler for open can be removed.
A lot of file names were stored in private char * pointers in the CommandLine class when the main application was looking at public std::string members. Remove the private mempers and store all file names in the public std::string members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux/GTK: fix command line parsing
Specifying any options on the command line besides the ROM dump aborts with "Unknown option <--option-name>". Also a lot of parsed file names were stored in private members of CommandLine and never exposed to the main application.