Skip to content

Conversation

@grebnetiew
Copy link
Contributor

Closes #8

@grebnetiew grebnetiew requested a review from ThomasTNO January 22, 2025 14:35
@github-actions
Copy link

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars

Show details

Sigrid compared your code against the baseline of 2024-11-04.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

You did not introduce any technical debt during your changes, great job!

📚 Remaining technical debt

1 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid** to explore your technical debt

⭐️ Sigrid ratings

System property System on 2024-11-04 Before changes New/changed code
Volume 5.5 N/A N/A
Duplication 5.5 5.5 5.5
Unit Size N/A N/A N/A
Unit Complexity N/A N/A N/A
Unit Interfacing N/A N/A N/A
Module Coupling N/A N/A N/A
Component Independence N/A N/A N/A
Component Entanglement N/A N/A N/A
Maintainability 5.5 5.5 5.5

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@grebnetiew grebnetiew self-assigned this Jan 22, 2025
Copy link
Member

@ThomasTNO ThomasTNO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomasTNO ThomasTNO merged commit 15bbd96 into main Jan 22, 2025
1 check passed
@ThomasTNO ThomasTNO deleted the accept-invalid-utf8 branch January 22, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Dummy server quits when invalid utf-8 is in the headers

3 participants