Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR addresses issue #158 by ensuring that if an event has multiple rooms listed in its location, all of them are shown in the notes with their respective NavigaTUM links.

Changes:

  • Modified internal/app.go regex reRoom to be non-greedy.
  • Modified internal/app.go cleanEvent to iterate over all found room IDs.
  • Added a new test case TestMultipleRooms in internal/app_test.go.

PR created automatically by Jules for task 6386064347777383797 started by @kordianbruck

- Updated `reRoom` regex to be non-greedy to correctly identify the first room in a list for the Location field.
- Updated `cleanEvent` to find all NavigaTUM room IDs in the location string and generate navigation links for each of them in the event description.
- Added `TestMultipleRooms` to verify the fix.

Fixes #158
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@kordianbruck kordianbruck marked this pull request as ready for review December 5, 2025 20:55
@kordianbruck kordianbruck merged commit 44b1ac2 into master Dec 5, 2025
1 check passed
@kordianbruck kordianbruck deleted the feature/multiple-rooms-notes-158 branch December 5, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants