Fix: Add thumbnail generation for .cbr and .cbz files #1052
Conversation
CyanVoxel
added
Type: Enhancement
|
Just wanna let all of you know that for cbz files in the comic/manga spaces it's common to find at the root of the archive a https://github.com/anansi-project/comicinfo |
There was a problem hiding this comment.
Thank you for submitting this, but I'm noticing a lot of fundamental issues with this one that suggests to me that it was not tested or that the new code was unknowingly overshadowed by the existing functionality inside the eBook rendering step (which includes .cbz but not .cbr).
If this PR was made in good faith, I recommend taking a look at the CONTRIBUTING.md page and making sure that this code is in a functional state. I've made a few surface level comments on some of the code, and I see you've already fixed the broken import.
| # Comic Book Archives ========================================= | ||
| elif ext in {".cbr", ".cbz"}: | ||
| image = self._render_comic_archive(str(_filepath), QSize(*base_size)) |
There was a problem hiding this comment.
Because this check is being made after the EBOOK_TYPES check which already includes these files, this code is not being ran.
| if not pixmap.loadFromData(image_data): | ||
| return None | ||
|
|
||
| return self.scale_pixmap(pixmap, size) |
There was a problem hiding this comment.
This is the incorrect return type. The ThumbRenderer expects a PIL type Image object, not a QPixmap. Also, this method does not exist.
Summary
Closes #1051
This PR adds thumbnail generation for
.cbrand.cbzfiles. The new logic reads the archive and uses the first internal image as the cover preview, fixing the bug where thumbnails were incorrect or missing.This change adds the
rarfiledependency topyproject.tomlfor.cbrsupport.Tasks Completed
Implemented a new rendering path for comic book archives in
thumb_renderer.py.Added the
rarfiledependency to support.cbrfiles.Platforms Tested:
.cbrand.cbzthumbnails now render correctly)