perf: Optimize db queries for preview panel #942
+74
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBobBobs
force-pushed
the
perf/preview_panel
branch
from
4ef7c13 to
59460e4
Compare
CyanVoxel
added
TagStudio: Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add method
get_tag_hierarchytoLibrarythat returns adict[TagId, list[ParentId]]anddict[TagId, Tag]containing every tag in the hierarchy. UpdateFieldContainersto use this new method.Currently all places that call
Library.tag_display_namealready have theTagobject so we don't need to fetch it from db.Tasks Completed