fix(QTDI-1686):[TCK Framework]: allow pass logical type when studio dynamic schema case #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypiel-talend
requested changes
Aug 8, 2025
| .withEntry(factory.newEntryBuilder() | ||
| .withName("time1") | ||
| .withType(Type.DATETIME) | ||
| .withProp(SchemaProperty.LOGICAL_TYPE, SchemaProperty.LogicalType.TIME.key()) |
There was a problem hiding this comment.
Don't use withProp(...) to set logical type, please use withLogicalType:
factory.newEntryBuilder()
.withName("date")
.withType(Type.DATETIME)
.withLogicalType(LogicalType.TIME)
| @@ -502,6 +514,9 @@ private Entry toEntry(final String name, final Schema.Type type, final String or | |||
| props.put(PATTERN, pattern); | |||
| } | |||
| props.put(STUDIO_TYPE, studioType); | |||
| if (logicalType != null) { | |||
There was a problem hiding this comment.
Please use withLogicalType in the "return factory..." don' put it in a temporary map taht will be used in withProps(...)
return factory
.newEntryBuilder()
.withName(name)
.withRawName(originalName)
.withNullable(isNullable)
.withType(type)
.withComment(comment)
.withDefaultValue(defaultValue)
.withProps(props)
.withLogicalType(SchemaProperty.LogicalType.valueOf(logicalType))
.build();
| @@ -306,7 +304,14 @@ private DynamicMetadataWrapper generateMetadata(final Entry entry) { | |||
|
|
|||
| switch (studioType) { | |||
| case StudioTypes.DATE: | |||
| metadata.getDynamicMetadata().setLogicalType("timestamp-millis"); | |||
| final String logicalType = entry.getProps().get(LOGICAL_TYPE); | |||
There was a problem hiding this comment.
Please use entry.getLogicalType()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Why this PR is needed?
https://qlik-dev.atlassian.net/browse/QTDI-1686
What does this PR adds (design/code thoughts)?
https://qlik-dev.atlassian.net/browse/QTDI-1686