-
Notifications
You must be signed in to change notification settings - Fork 50
fix(QTDI-1856): remove empty raw name for list #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where list/array fields in schema entries were incorrectly assigned empty raw names instead of null values. The fix ensures that only fields with actual original database column names have their rawName
property set, while others remain null.
- Replace empty string raw names with null for list entries without original names
- Set original database column name as raw name for list entries that have one
- Add comprehensive test coverage for both scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
DiRowStructVisitor.java | Modified toCollectionEntry method to conditionally set raw name only when original name exists |
DiRowStructVisitorTest.java | Added test assertions to verify correct handling of list entries with and without original names |
VisitorsTest.java | Added method to provide original database column name for test data |
...-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/record/DiRowStructVisitor.java
Outdated
Show resolved
Hide resolved
b9502d9
to
b322625
Compare
* replace it with the null * set original value for inferschema
5393d95
to
002d87f
Compare
|
Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?