Skip to content

Conversation

ozhelezniak-talend
Copy link
Contributor

  • replace it with the null
  • set original value for inferschema

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

What does this PR adds (design/code thoughts)?

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where list/array fields in schema entries were incorrectly assigned empty raw names instead of null values. The fix ensures that only fields with actual original database column names have their rawName property set, while others remain null.

  • Replace empty string raw names with null for list entries without original names
  • Set original database column name as raw name for list entries that have one
  • Add comprehensive test coverage for both scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
DiRowStructVisitor.java Modified toCollectionEntry method to conditionally set raw name only when original name exists
DiRowStructVisitorTest.java Added test assertions to verify correct handling of list entries with and without original names
VisitorsTest.java Added method to provide original database column name for test data

@ozhelezniak-talend ozhelezniak-talend force-pushed the ozhelezniak/QTDI-1856_list_raw_name branch from b9502d9 to b322625 Compare August 7, 2025 11:08
@ozhelezniak-talend ozhelezniak-talend force-pushed the ozhelezniak/QTDI-1856_list_raw_name branch from 5393d95 to 002d87f Compare August 11, 2025 07:38
Copy link

sonar-eks bot commented Aug 11, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants