feat: prevent overwriting non-empty directories #220
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morinokami
commented
Oct 31, 2025
| import type { AddOn, PackageManager } from '@tanstack/cta-engine' | ||
|
|
||
| import type { Framework } from '@tanstack/cta-engine/dist/types/types.js' | ||
| import { InitialData } from '../../cta-ui/src/types' |
Contributor
Author
There was a problem hiding this comment.
It’s not part of the main change, but I removed an unused import.
|
I think it will be better to let people choose like
source issue: #198 |
Contributor
Author
|
@WahidinAji Thank you for your feedback! I've updated the code and it now asks the user for confirmation before exiting: 
|
Collaborator
|
It needs a force flag. |
Contributor
Author
|
@jherr I've added a |
morinokami
commented
Dec 2, 2025
Comment on lines
-15
to
+17
| selectGit, | ||
| selectDeployment, | ||
| selectGit, |
Contributor
Author
There was a problem hiding this comment.
Fixed ESLint's sort-imports warning introduced in c2ef696.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation in
packages/cta-cli/src/options.tsto check whether the target directory exists and is non-empty. Previously, the CLI would overwrite existing files. Now it exits with an error message instead.Closes #198.